Use psutil to terminate processes when available#142
Merged
ogrisel merged 2 commits intojoblib:masterfrom Aug 1, 2018
Merged
Conversation
This is useful on POSIX systems where pgrep is not installed such as minimal docker images for instance.
tomMoral
reviewed
Aug 16, 2018
|
|
||
| for child in children: | ||
| try: | ||
| child.terminate() |
Contributor
There was a problem hiding this comment.
We should directly call kill as the goal of recursive_terminate is to forcefully clean-up the remaining worker when the executor is not in a proper state.
Right now, this makes it very slow to kill workers and the test max_depth takes more than 1:30min. Another solution is to reduce the timeout line 39.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful on POSIX systems where pgrep is not installed such
as minimal docker images for instance.
The issue was found by @yarikoptic on the debian build system.