Skip to content

Related Posts: Make sure we escape the excerpt#1

Merged
jeherve merged 1 commit intojeherve:fix/related-posts-excerpts-ellipsisfrom
xyu:PR1282
May 21, 2015
Merged

Related Posts: Make sure we escape the excerpt#1
jeherve merged 1 commit intojeherve:fix/related-posts-excerpts-ellipsisfrom
xyu:PR1282

Conversation

@xyu
Copy link
Copy Markdown

@xyu xyu commented May 21, 2015

fa0ba20 started calling html_entity_decode() on the excerpt so we should
escape it when outputing to avoid potential XSS.

fa0ba20 started calling `html_entity_decode()` on the excerpt so we should
escape it when outputing to avoid potential XSS.
jeherve added a commit that referenced this pull request May 21, 2015
Related Posts: Make sure we escape the excerpt
@jeherve jeherve merged commit 129d3e0 into jeherve:fix/related-posts-excerpts-ellipsis May 21, 2015
jeherve pushed a commit that referenced this pull request Aug 13, 2015
Gallery functions: fix a few indentation issues
jeherve pushed a commit that referenced this pull request Aug 23, 2015
jeherve pushed a commit that referenced this pull request Jul 20, 2016
jeherve pushed a commit that referenced this pull request Jul 20, 2016
After The Deadline: add spaces for WP coding standards.
jeherve pushed a commit that referenced this pull request Aug 30, 2022
* PHP Deprecated: strpos(): Passing null to parameter #1 () of type string is deprecated in /wordpress/plugins/jetpack/11.3-a.7/functions.compat.php on line 94

* Add unit tests

* Update other functions

* Fix situations with arrays

* PHPCS exclusion for PHP 8.0 functions
jeherve pushed a commit that referenced this pull request Jan 14, 2025
…ttic#40610)

* Jetpack AI: Add thumbs up/down component to AI logo generator

* changelog

* Attemp #1 to fix some build errors

* changelog

* add base-styles to jetpack ai client

* move AiFeedbackThumbs to ai client

* avoid multiple events on same rating

* store rating with other logo information

* fix issue with persisting ratings with modal open

* add mediaLibraryId, prompt and revisedPrompt to event

---------

Co-authored-by: Douglas <douglas.henri@automattic.com>
jeherve added a commit that referenced this pull request Jun 11, 2025
…attic#43396)

* Stats: avoid trying to access formatter for unavailable locale

This should avoid errors like:

Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid

Internal reference: p1746629628168729-slack-CDLH4C1UZ

Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example.

* Extract locale check to speed up locale detection

See Automattic#43396 (comment)

* Get locale with an underscore instead of dash

The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3.

* Add test for new method

* Avoid static analysis error
jeherve added a commit that referenced this pull request Jan 13, 2026
…#45387)

Fixes Automattic#45386

This should avoid errors like this one:

```
An error of type E_ERROR was caused in line 298 of the file wp-content/plugins/jetpack/modules/photon-cdn.php. Error message: Uncaught TypeError: array_keys(): Argument #1 ($array) must be of type array, null given in wp-content/plugins/jetpack/modules/photon-cdn.php:298
```

Co-authored-by: toothybrando@users.noreply.github.com
jeherve added a commit that referenced this pull request Jan 13, 2026
…ttic#46283)

* Jetpack settings: override module list & debugger page titles

Fixes JETPACK-1008

When registering the Module list page and the Jetpack Debugger page, we do not want the page to appear in the admin menu. This causes us to run into this issue:
- https://core.trac.wordpress.org/ticket/57579
- Automattic#46214

```
Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in …/wp-admin/admin-header.php on line 41
```

Let's override the title when we're on those pages to avoid the deprecation warning and have a proper page title on those 2 pages.

Co-authored-by: Weston Ruter <weston@xwp.co>

* changelog

* Change hook registration to match static declaration

See Automattic#46283 (comment)

---------

Co-authored-by: Weston Ruter <weston@xwp.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants