Stats: avoid trying to access formatter for unavailable locale#43396
Merged
Stats: avoid trying to access formatter for unavailable locale#43396
Conversation
This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request prevents PHP fatal errors in the Stats column by ensuring that an invalid locale is replaced with a fallback locale ("en_US") when constructing the NumberFormatter.
- Added a locale validity check with a fallback in the get_formatter method.
- Included a changelog entry detailing the fix for the locale issue.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/packages/stats-admin/src/class-admin-post-list-column.php | Added a locale availability check and fallback logic in the get_formatter method. |
| projects/packages/stats-admin/changelog/fix-php84-locale-error-stats | Added a changelog entry describing the PHP fatal error fix. |
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3.
kangzj
approved these changes
May 7, 2025
Contributor
kangzj
left a comment
There was a problem hiding this comment.
Works well and looks good! Thanks fixing this 👍
matticbot
pushed a commit
to Automattic/jetpack-stats-admin
that referenced
this pull request
May 8, 2025
* Stats: avoid trying to access formatter for unavailable locale This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example. * Extract locale check to speed up locale detection See Automattic/jetpack#43396 (comment) * Get locale with an underscore instead of dash The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3. * Add test for new method * Avoid static analysis error Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14900742224 Upstream-Ref: Automattic/jetpack@bdb2551
matticbot
pushed a commit
to Automattic/jetpack-storybook
that referenced
this pull request
May 8, 2025
* Stats: avoid trying to access formatter for unavailable locale This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example. * Extract locale check to speed up locale detection See Automattic/jetpack#43396 (comment) * Get locale with an underscore instead of dash The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3. * Add test for new method * Avoid static analysis error Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14900742224 Upstream-Ref: Automattic/jetpack@bdb2551
matticbot
pushed a commit
to Automattic/jetpack-mu-wpcom
that referenced
this pull request
May 8, 2025
* Stats: avoid trying to access formatter for unavailable locale This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example. * Extract locale check to speed up locale detection See Automattic/jetpack#43396 (comment) * Get locale with an underscore instead of dash The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3. * Add test for new method * Avoid static analysis error Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14900742224 Upstream-Ref: Automattic/jetpack@bdb2551
matticbot
pushed a commit
to Automattic/jetpack-mu-wpcom-plugin
that referenced
this pull request
May 8, 2025
* Stats: avoid trying to access formatter for unavailable locale This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example. * Extract locale check to speed up locale detection See Automattic/jetpack#43396 (comment) * Get locale with an underscore instead of dash The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3. * Add test for new method * Avoid static analysis error Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14900742224 Upstream-Ref: Automattic/jetpack@bdb2551
matticbot
pushed a commit
to Automattic/wpcom-site-helper
that referenced
this pull request
May 8, 2025
* Stats: avoid trying to access formatter for unavailable locale This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example. * Extract locale check to speed up locale detection See Automattic/jetpack#43396 (comment) * Get locale with an underscore instead of dash The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3. * Add test for new method * Avoid static analysis error Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14900742224 Upstream-Ref: Automattic/jetpack@bdb2551
matticbot
pushed a commit
to Automattic/jetpack-production
that referenced
this pull request
May 8, 2025
* Stats: avoid trying to access formatter for unavailable locale This should avoid errors like: Fatal error: Uncaught ValueError: NumberFormatter::__construct(): Argument #1 ($locale) "skr" is invalid Internal reference: p1746629628168729-slack-CDLH4C1UZ Some of the locale codes we pass to NumberFormatter are not always available. `skr` is a good example. * Extract locale check to speed up locale detection See Automattic/jetpack#43396 (comment) * Get locale with an underscore instead of dash The dash is appropriate to display the language code in HTML, but is not valid ISO 639-3. * Add test for new method * Avoid static analysis error Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14900742224 Upstream-Ref: Automattic/jetpack@bdb2551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
This should avoid errors like:
Some of the locale codes we pass to NumberFormatter are not always available.
skris a good example. I've detailed this problem in this issue: php/php-src#18515Other information:
Jetpack product discussion
Internal reference: p1746629628168729-slack-CDLH4C1UZ
Does this pull request change what data or activity we track or use?
Testing instructions: