Jetpack settings: override module list & debugger page titles by jeherve · Pull Request #46283 · Automattic/jetpack

jeherve · 2025-12-12T11:33:42Z

Proposed changes:

When registering the Module list page and the Jetpack Debugger page, we do not want the page to appear in the admin menu. This causes us to run into this issue:

Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in …/wp-admin/admin-header.php on line 41

Let's override the title when we're on those pages to avoid the deprecation warning and have a proper page title on those 2 pages.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

On a site with Jetpack installed, go to the following pages
- mysite.com/wp-admin/admin.php?page=jetpack-debugger
- mysite.com/wp-admin/admin.php?page=jetpack_modules
Check the page title: it should match the titles set in this PR.
Check your site's error logs: you should not see any errors.
Check the Jetpack menu in wp-admin: you should not see those 2 pages.

Fixes JETPACK-1008 When registering the Module list page and the Jetpack Debugger page, we do not want the page to appear in the admin menu. This causes us to run into this issue: - https://core.trac.wordpress.org/ticket/57579 - #46214 ``` Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in …/wp-admin/admin-header.php on line 41 ``` Let's override the title when we're on those pages to avoid the deprecation warning and have a proper page title on those 2 pages. Co-authored-by: Weston Ruter <weston@xwp.co>

github-actions · 2025-12-12T11:34:38Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/missing-title-wp-admin-settings branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/missing-title-wp-admin-settings

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-12-12T11:34:46Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: January 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-12-12T11:44:32Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php	0/193 (0.00%)	0.00%	5 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

Copilot

Pull request overview

This PR fixes a deprecation warning that occurs when loading the Jetpack Settings screen (module list page) and the Debugging Center page. These pages are registered as "hidden" admin pages (with empty parent slug) to prevent them from appearing in the admin menu, which causes WordPress's strip_tags() function to receive a null title parameter. The fix manually overrides the page titles using the current_screen action hook to provide proper titles for both pages.

Key Changes

Added a new override_page_title() method to set explicit page titles for hidden admin pages
Hooked this method to the current_screen action in the add_actions() method
Added changelog entry documenting the bugfix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
projects/plugins/jetpack/changelog/fix-missing-title-wp-admin-settings	Adds changelog entry documenting the deprecation notice fix
projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php	Adds `override_page_title()` method and registers it on `current_screen` hook to set titles for jetpack_modules and jetpack-debugger pages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php

manzoorwanijk · 2025-12-12T11:54:57Z

projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php

+		global $title;
+		if ( 'admin_page_jetpack_modules' === $screen->id ) {
+			$title = __( 'Jetpack Settings', 'jetpack' ); // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- we override the title global only on this page.
+		} elseif ( 'admin_page_jetpack-debugger' === $screen->id ) {
+			$title = __( 'Debugging Center', 'jetpack' ); // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- we override the title global only on this page.
+		}


Can we use the admin_title filter instead of modifying the global? Or is that different than the title we are trying to modify here?

We could, but since the filter is declared later (see https://github.com/WordPress/wordpress-develop/blob/48b2b65eb7f719936260b8ece17b8847d264eec5/src/wp-admin/admin-header.php#L89 ), we would still get the PHP warning.

…-admin-settings

See #46283 (comment)

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

manzoorwanijk

This looks good to me now. Thanks

* Jetpack settings: override module list & debugger page titles Fixes JETPACK-1008 When registering the Module list page and the Jetpack Debugger page, we do not want the page to appear in the admin menu. This causes us to run into this issue: - https://core.trac.wordpress.org/ticket/57579 - Automattic/jetpack#46214 ``` Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in …/wp-admin/admin-header.php on line 41 ``` Let's override the title when we're on those pages to avoid the deprecation warning and have a proper page title on those 2 pages. Co-authored-by: Weston Ruter <weston@xwp.co> * changelog * Change hook registration to match static declaration See Automattic/jetpack#46283 (comment) --------- Co-authored-by: Weston Ruter <weston@xwp.co> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/20262979158 Upstream-Ref: Automattic/jetpack@cab13aa

jeherve and others added 2 commits December 12, 2025 12:27

changelog

135d2fb

jeherve self-assigned this Dec 12, 2025

jeherve added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Pri] Low Bug labels Dec 12, 2025

jeherve mentioned this pull request Dec 12, 2025

PHP Deprecation Notice: strip_tags(): Passing null #46214

Closed

jeherve requested a review from a team December 12, 2025 11:34

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Dec 12, 2025

manzoorwanijk requested a review from Copilot December 12, 2025 11:48

Copilot started reviewing on behalf of manzoorwanijk December 12, 2025 11:48 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php Outdated Show resolved Hide resolved

manzoorwanijk reviewed Dec 12, 2025

View reviewed changes

jeherve added 2 commits December 12, 2025 18:53

Merge remote-tracking branch 'origin/trunk' into fix/missing-title-wp…

6f9eb73

…-admin-settings

Change hook registration to match static declaration

e444b33

See #46283 (comment)

jeherve requested review from Copilot and manzoorwanijk December 12, 2025 18:08

Copilot started reviewing on behalf of jeherve December 12, 2025 18:09 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

manzoorwanijk approved these changes Dec 16, 2025

View reviewed changes

jeherve merged commit cab13aa into trunk Dec 16, 2025
74 of 75 checks passed

jeherve deleted the fix/missing-title-wp-admin-settings branch December 16, 2025 09:27

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Dec 16, 2025

github-actions bot added this to the jetpack/15.4 milestone Dec 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jetpack settings: override module list & debugger page titles#46283

Jetpack settings: override module list & debugger page titles#46283
jeherve merged 4 commits intotrunkfrom
fix/missing-title-wp-admin-settings

jeherve commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

manzoorwanijk Dec 12, 2025

Uh oh!

jeherve Dec 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

manzoorwanijk left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jeherve commented Dec 12, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

manzoorwanijk Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

jeherve Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 12, 2025 •

edited

Loading

github-actions bot commented Dec 12, 2025 •

edited

Loading

jp-launch-control bot commented Dec 12, 2025 •

edited

Loading