Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI linting configuration issue where the linting tasks were only running on staged files instead of all files. The PR adds the --all flag to both hk check and hk fix commands in the mise task configuration, ensuring comprehensive linting in CI. Additionally, it fixes a clippy warning that was able to slip through due to this linting gap.
Changes:
- Added
--allflag tohk checkandhk fixcommands in mise.toml - Fixed a clippy warning in stop.rs by simplifying a boolean expression
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mise.toml | Updated lint and lint-fix tasks to run on all files instead of only staged files |
| src/cli/stop.rs | Simplified boolean logic to address clippy warning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hk check/fix without --all only runs on staged files, which means CI was skipping lint checks entirely. This also fixes a clippy warning that slipped through. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merged
jdx
added a commit
that referenced
this pull request
Feb 1, 2026
## 🤖 New release * `pitchfork-cli`: 1.2.0 -> 1.3.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [1.3.0](v1.2.0...v1.3.0) - 2026-02-01 ### Added - *(list)* show available daemons and align logics with TUI ([#206](#206)) - *(logs)* support `--since <humantime>`, use pager by default ([#204](#204)) - support `pitchfork.local.toml` ([#198](#198)) - impl `stop --all` ([#195](#195)) - beautify web ui ([#191](#191)) - add ready_cmd option ([#187](#187)) ### Fixed - refactor the logic of stopping a daemon and add tests ([#192](#192)) ### Other - re-order code to suit for multi-frontend structure ([#197](#197)) - *(deps)* update rust crate xx to v2.3.1 ([#203](#203)) - *(deps)* update rust crate clap to v4.5.56 ([#202](#202)) - *(ci)* run linting on all files in CI ([#196](#196)) - Update README.md logo ([#184](#184)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this PR only updates version numbers and release notes/docs, with no runtime code changes. > > **Overview** > Releases **v1.3.0** by bumping the crate version from `1.2.0` to `1.3.0` (including `Cargo.lock`) and updating the `pitchfork.usage.kdl`/generated CLI docs to match. > > Updates `CHANGELOG.md` with the `1.3.0` release notes and links to the included feature/fix PRs. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d278b90. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allflag tohk checkandhk fixin mise tasks🤖 Generated with Claude Code
Note
Enables full-repo linting in CI and addresses a minor lint in the CLI.
mise.tomlto runhk check --allandhk fix --allso CI linting covers all filesStop::runargument validation insrc/cli/stop.rsto satisfy clippy (logical equivalence)CRUSH.mdwith pitchfork-specificfeat/fixscope and addchore(ci)/chore(deps)examplesWritten by Cursor Bugbot for commit 90cc5d1. This will update automatically on new commits. Configure here.