Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the stop --all feature with reverse dependency order handling, provides helpful feedback when trying to start already-running daemons, and modernizes the codebase with inline format string syntax.
Changes:
- Implements
stop --allthat stops all running daemons in reverse dependency order (dependents stopped before dependencies) - Adds informative message when attempting to start an already-running daemon (suggests using
--force) - Optimizes e2e test reliability by increasing log flush wait times from 100ms to 500ms
- Modernizes ~100+ format strings across the codebase to use inline syntax (e.g.,
format!("{}", x)→format!("{x}"))
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/cli/stop.rs |
Implements stop --all with dependency-aware stopping logic, handles ad-hoc and config-based daemons separately |
src/cli/start.rs |
Adds info message when daemon is already running without --force |
tests/test_e2e_depends.rs |
Adds 3 comprehensive tests for stop --all covering various scenarios |
tests/test_e2e.rs |
Updates test sleep times for log assertions (100ms → 500ms) and format strings |
tests/test_e2e_*.rs |
Modernizes format strings to inline syntax |
src/**/*.rs |
Modernizes format strings throughout the codebase |
docs/cli/*.md |
Updates CLI documentation for new --all flag |
pitchfork.usage.kdl |
Updates usage specification for stop command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
bugbot run |
Contributor
Author
no reaction from cursor? @jdx |
Owner
|
bugbot run |
Merged
jdx
added a commit
that referenced
this pull request
Feb 1, 2026
## 🤖 New release * `pitchfork-cli`: 1.2.0 -> 1.3.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [1.3.0](v1.2.0...v1.3.0) - 2026-02-01 ### Added - *(list)* show available daemons and align logics with TUI ([#206](#206)) - *(logs)* support `--since <humantime>`, use pager by default ([#204](#204)) - support `pitchfork.local.toml` ([#198](#198)) - impl `stop --all` ([#195](#195)) - beautify web ui ([#191](#191)) - add ready_cmd option ([#187](#187)) ### Fixed - refactor the logic of stopping a daemon and add tests ([#192](#192)) ### Other - re-order code to suit for multi-frontend structure ([#197](#197)) - *(deps)* update rust crate xx to v2.3.1 ([#203](#203)) - *(deps)* update rust crate clap to v4.5.56 ([#202](#202)) - *(ci)* run linting on all files in CI ([#196](#196)) - Update README.md logo ([#184](#184)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this PR only updates version numbers and release notes/docs, with no runtime code changes. > > **Overview** > Releases **v1.3.0** by bumping the crate version from `1.2.0` to `1.3.0` (including `Cargo.lock`) and updating the `pitchfork.usage.kdl`/generated CLI docs to match. > > Updates `CHANGELOG.md` with the `1.3.0` release notes and links to the included feature/fix PRs. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d278b90. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop --all, considering dependency order, and add e2e tests for it