Conversation
Contributor
Author
|
Once we agree on implementation I'll add the docs for this feature. I'd like to keep it to code in first commit. |
Contributor
Author
|
Updated docs and made the branch ready. |
TheFedaikin
commented
Jan 23, 2026
| // Setup command readiness check interval (poll every 500ms) | ||
| let mut cmd_check_interval = ready_cmd | ||
| .as_ref() | ||
| .map(|_| tokio::time::interval(Duration::from_millis(500))); |
Contributor
Author
There was a problem hiding this comment.
Should this be extracted to const at the top of the file and be configurable in the future? I think for cmd it's probably the most needed one, as some of them are expensive and can run more than an interval duration.
Contributor
There was a problem hiding this comment.
we need it to be configuable in the future
gaojunran
approved these changes
Jan 25, 2026
Contributor
There was a problem hiding this comment.
there may have been a lib to do this abstraction. but you finish it with full tests and I think it's ok
| // Setup command readiness check interval (poll every 500ms) | ||
| let mut cmd_check_interval = ready_cmd | ||
| .as_ref() | ||
| .map(|_| tokio::time::interval(Duration::from_millis(500))); |
Contributor
There was a problem hiding this comment.
we need it to be configuable in the future
Owner
|
bugbot run |
Merged
jdx
added a commit
that referenced
this pull request
Feb 1, 2026
## 🤖 New release * `pitchfork-cli`: 1.2.0 -> 1.3.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [1.3.0](v1.2.0...v1.3.0) - 2026-02-01 ### Added - *(list)* show available daemons and align logics with TUI ([#206](#206)) - *(logs)* support `--since <humantime>`, use pager by default ([#204](#204)) - support `pitchfork.local.toml` ([#198](#198)) - impl `stop --all` ([#195](#195)) - beautify web ui ([#191](#191)) - add ready_cmd option ([#187](#187)) ### Fixed - refactor the logic of stopping a daemon and add tests ([#192](#192)) ### Other - re-order code to suit for multi-frontend structure ([#197](#197)) - *(deps)* update rust crate xx to v2.3.1 ([#203](#203)) - *(deps)* update rust crate clap to v4.5.56 ([#202](#202)) - *(ci)* run linting on all files in CI ([#196](#196)) - Update README.md logo ([#184](#184)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this PR only updates version numbers and release notes/docs, with no runtime code changes. > > **Overview** > Releases **v1.3.0** by bumping the crate version from `1.2.0` to `1.3.0` (including `Cargo.lock`) and updating the `pitchfork.usage.kdl`/generated CLI docs to match. > > Updates `CHANGELOG.md` with the `1.3.0` release notes and links to the included feature/fix PRs. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d278b90. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion I started implementing the
ready_cmdfeature.Outstanding questions:
Note
Adds a new readiness check that polls a shell command and integrates it across CLI, config, schema, supervisor, and UI.
ready_cmdinpitchfork.toml, JSON Schema, and docs; new--cmd <CMD>flag forstart/runready_cmdthroughRunOptions, daemon state, IPC, restart/retry/watchers/boot paths, TUI, and web routesshellmodule and uses it in supervisor lifecycle to run readiness commands (500ms polling)Written by Cursor Bugbot for commit 1055b3c. This will update automatically on new commits. Configure here.