Skip to content

refactor(deps): remove serde_derive dependency#9670

Merged
jdx merged 2 commits intojdx:mainfrom
risu729:codex/remove-serde-derive-dependency
May 7, 2026
Merged

refactor(deps): remove serde_derive dependency#9670
jdx merged 2 commits intojdx:mainfrom
risu729:codex/remove-serde-derive-dependency

Conversation

@risu729
Copy link
Copy Markdown
Contributor

@risu729 risu729 commented May 7, 2026

This doesn't change anything, just how to import the crate.

Summary

  • remove direct serde_derive dependencies from the main crate and crates/aqua-registry
  • enable serde's derive feature in the main crate
  • switch remaining derive imports and paths to serde's re-exported macros

Dependency audit

  • rg serde_derive Cargo.toml crates/aqua-registry/Cargo.toml src crates/aqua-registry/src build.rs has no direct hits after the change
  • cargo tree -p mise --depth 1 --edges normal,build,dev no longer lists serde_derive as a direct mise dependency
  • cargo tree -p aqua-registry --depth 1 --edges normal,build,dev no longer lists serde_derive as a direct aqua-registry dependency
  • serde_derive still appears transitively as serde's derive macro implementation

Verification

  • cargo fmt --check
  • cargo check -p mise --all-targets
  • cargo check -p aqua-registry --all-targets

This PR was generated by an AI coding assistant.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Greptile Summary

This PR consolidates the serde_derive crate as a direct dependency by removing it from both Cargo.toml and crates/aqua-registry/Cargo.toml, enabling serde's built-in derive feature flag instead. All 23 source-file changes are purely mechanical import path updates — use serde_derive::X becomes use serde::X — with no logic changes.

  • Removes explicit serde_derive = \"1\" entries from the two Cargo.toml files and enables serde = { version = \"1\", features = [\"derive\"] } in their place.
  • Updates every use serde_derive::{Deserialize, Serialize} import across the main crate and aqua-registry, plus one inline #[derive(serde_derive::Deserialize)] inside src/lockfile.rs.

Confidence Score: 5/5

Safe to merge — this is a mechanical import-path refactoring with no logic changes.

Every change is a one-for-one swap of serde_derive::X for serde::X backed by serde's re-exported macros when the derive feature is enabled. The aqua-registry crate already had features = ["derive"] on its serde dependency, and the main crate's dependency is updated accordingly. No runtime behavior changes.

No files require special attention.

Reviews (2): Last reviewed commit: "Merge branch 'main' into codex/remove-se..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates the serde and serde_derive dependencies by enabling the derive feature on the serde crate and removing serde_derive as a standalone dependency across the workspace. This involves updates to Cargo.toml and Cargo.lock files, as well as updating import statements in numerous Rust source files to use serde directly for Serialize and Deserialize traits. I have no feedback to provide.

@risu729

This comment was marked as outdated.

@risu729 risu729 marked this pull request as ready for review May 7, 2026 07:59
@jdx jdx merged commit b360191 into jdx:main May 7, 2026
34 of 35 checks passed
@risu729 risu729 deleted the codex/remove-serde-derive-dependency branch May 7, 2026 11:17
mise-en-dev added a commit that referenced this pull request May 7, 2026
### 🚀 Features

- **(aqua)** support registry libc variants by @jdx in
[#9652](#9652)
- **(bin-paths)** add executable names output by @risu729 in
[#9617](#9617)

### 🐛 Bug Fixes

- **(aqua)** preserve configured file extensions by @risu729 in
[#9611](#9611)
- **(aqua)** support registry file links by @risu729 in
[#9610](#9610)
- **(backend)** reject bare package backend names by @risu729 in
[#9608](#9608)
- **(backend)** apply inline tool option overrides by @risu729 in
[#9306](#9306)
- **(backend)** skip versions host for local tool opts by @risu729 in
[#9568](#9568)
- **(github)** chmod explicit archive bin by @risu729 in
[#9609](#9609)
- **(install)** skip remote-versions refresh in prefer-offline mode by
@jdx in [#9627](#9627)
- **(lock)** scope targets to active project root by @risu729 in
[#9319](#9319)
- **(lockfile)** respect existing platforms during auto-lock by @jdx in
[#9621](#9621)
- **(pipx)** filter yanked pypi releases by @risu729 in
[#9607](#9607)
- **(pipx)** declare python as a backend dependency by @jdx in
[#9678](#9678)
- **(schema)** update refs to $defs in mise-registry-tool.json by
@risu729 in [#9671](#9671)
- **(task)** terminate parallel siblings on failure via process groups
by @jdx in [#9655](#9655)
- **(task)** stable MISE_PROJECT_ROOT for monorepo tasks, add
MISE_MONOREPO_ROOT by @jdx in
[#9657](#9657)
- **(trust)** run enter hooks after trusting config by @risu729 in
[#9634](#9634)
- **(ui)** stop clearing screen for prompts by @jdx in
[#9619](#9619)
- use /bin/cp on macos by @pdehlke in
[#9656](#9656)

### 🚜 Refactor

- **(aqua)** store aqua var defaults as strings by @risu729 in
[#9645](#9645)
- **(config)** support structured TOML values in registry backend
options by @risu729 in [#9584](#9584)
- **(deps)** remove serde_derive dependency by @risu729 in
[#9670](#9670)
- **(deps)** remove anyhow dependency by @risu729 in
[#9661](#9661)
- **(deps)** use std::sync::LazyLock instead of once_cell::Lazy by
@risu729 in [#9668](#9668)
- **(schema)** generate task schema from mise schema by @risu729 in
[#9581](#9581)
- **(schema)** reuse task props with unevaluatedProperties by @risu729
in [#9582](#9582)
- **(schema)** reuse registry common types by @risu729 in
[#9648](#9648)
- **(schema)** reuse plugin script config by @risu729 in
[#9647](#9647)
- **(schema)** use $defs in schema files by @risu729 in
[#9646](#9646)

### 📚 Documentation

- **(node)** add tips for enabling node idiomatic by @fu050409 in
[#9675](#9675)

### 🧪 Testing

- **(cli)** remove nondeterministic tool depends assertion by @risu729
in [#9633](#9633)
- **(e2e)** pin uv to 0.11.8 around astral-sh/uv#19278 by @jdx in
[#9618](#9618)
- **(e2e)** wait for docker env cleanup by @risu729 in
[#9631](#9631)
- **(zig)** use official zig instead of mach mirror by @jdx in
[#9659](#9659)

### 📦️ Dependency Updates

- fall through to hash check when providers have no outputs by @jdx in
[#9622](#9622)
- bump Cargo.lock by @jdx in
[#9625](#9625)

### 📦 Registry

- remove registry depends by @risu729 in
[#9571](#9571)
- add code-review-graph (pipx:code-review-graph) by @chautruonglong in
[#9673](#9673)

### Chore

- **(ci)** split large registry test-tool changes by @risu729 in
[#9628](#9628)
- **(ci)** make perf script robust to runner noise by @jdx in
[#9635](#9635)
- **(ci)** skip hyperfine comments without permission by @risu729 in
[#9629](#9629)

### New Contributors

- @chautruonglong made their first contribution in
[#9673](#9673)
- @pdehlke made their first contribution in
[#9656](#9656)

## 📦 Aqua Registry Updates

### New Packages (5)

-
[`anthropics/anthropic-cli`](https://github.com/anthropics/anthropic-cli)
- [`crates.io/wasmi_cli`](https://github.com/wasmi-labs/wasmi)
- [`openclaw/gogcli`](https://github.com/openclaw/gogcli)
- `racket-lang.org/racket-minimal`
- [`runs-on/cli`](https://github.com/runs-on/cli)

### Updated Packages (13)

- [`UpCloudLtd/upcloud-cli`](https://github.com/UpCloudLtd/upcloud-cli)
- [`aristocratos/btop`](https://github.com/aristocratos/btop)
- [`dprint/dprint`](https://github.com/dprint/dprint)
- [`j178/prek`](https://github.com/j178/prek)
- [`jdx/hk`](https://github.com/jdx/hk)
- [`jdx/mise`](https://github.com/jdx/mise)
- [`jdx/usage`](https://github.com/jdx/usage)
- [`jreleaser/jreleaser`](https://github.com/jreleaser/jreleaser)
-
[`jreleaser/jreleaser/standalone`](https://github.com/jreleaser/jreleaser)
- [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
- [`suzuki-shunsuke/cmdx`](https://github.com/suzuki-shunsuke/cmdx)
- [`suzuki-shunsuke/ghir`](https://github.com/suzuki-shunsuke/ghir)
- [`twpayne/chezmoi`](https://github.com/twpayne/chezmoi)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants