Skip to content

refactor(schema): use $defs in schema files#9646

Merged
jdx merged 2 commits intojdx:mainfrom
risu729:codex/schema-dollar-defs
May 7, 2026
Merged

refactor(schema): use $defs in schema files#9646
jdx merged 2 commits intojdx:mainfrom
risu729:codex/schema-dollar-defs

Conversation

@risu729
Copy link
Copy Markdown
Contributor

@risu729 risu729 commented May 6, 2026

Why

#9582 moved the generated schemas onto the JSON Schema draft 2020-12 shape we need for allOf + unevaluatedProperties. Once we rely on that behavior, the remaining schema files should use the draft 2020-12 definition namespace consistently.

Keeping definitions around works in some validators as legacy compatibility, but it leaves these files half-migrated: new reusable schema pieces are expected to live under $defs, while older local refs still point at #/definitions/.... This PR finishes that migration for the settings and registry-tool schemas so follow-up schema refactors can add shared definitions without mixing two local-ref conventions.

What changed

  • Migrates schema/mise-settings.json and schema/mise-registry-tool.json from definitions to $defs.
  • Updates local refs from #/definitions/... to #/$defs/....
  • Keeps the accepted schema values unchanged; this is a namespace/ref cleanup for draft 2020-12 consistency.

Validation

  • jq empty schema/mise-settings.json schema/mise-registry-tool.json
  • git diff --check

This PR was generated by an AI coding assistant.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 6, 2026

Greptile Summary

This PR migrates schema/mise-registry-tool.json and schema/mise-settings.json from the legacy definitions keyword to the Draft 2020-12 canonical $defs keyword, and updates all internal $ref paths accordingly.

  • Both schema files already declare \"$schema\": \"https://json-schema.org/draft/2020-12/schema\", so $defs is the correct keyword; this brings the definition location into alignment with the declared dialect.
  • All six $ref occurrences in mise-registry-tool.json and two in mise-settings.json are consistently updated from #/definitions/... to #/$defs/..., with no logic changes.

Confidence Score: 5/5

Purely mechanical rename of a schema keyword with no behavioral changes; both files correctly declare Draft 2020-12 and all refs are consistently updated.

The change is a straightforward keyword rename (definitions$defs) across two JSON Schema files that already declare the 2020-12 dialect. Every $ref is updated in lockstep. No logic is altered.

No files require special attention.

Reviews (6): Last reviewed commit: "refactor(schema): migrate registry optio..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JSON schemas for the project by replacing 'additionalProperties: false' with 'unevaluatedProperties: false' to better support property inheritance through $refs. It also updates the schema definitions to use '$defs' instead of 'definitions', refactors task property definitions to share common properties via 'allOf' and '$refs', and updates the associated TypeScript generation script to reflect these changes. Additionally, the regression test for tombi has been updated to use a newer version and includes a version check.

@risu729 risu729 marked this pull request as draft May 6, 2026 13:21
@risu729

This comment was marked as outdated.

@risu729 risu729 force-pushed the codex/schema-dollar-defs branch from 924c97d to 198d806 Compare May 6, 2026 23:44
@risu729 risu729 marked this pull request as ready for review May 6, 2026 23:50
@jdx jdx merged commit 494174d into jdx:main May 7, 2026
35 checks passed
@risu729 risu729 deleted the codex/schema-dollar-defs branch May 7, 2026 00:34
mise-en-dev added a commit that referenced this pull request May 7, 2026
### 🚀 Features

- **(aqua)** support registry libc variants by @jdx in
[#9652](#9652)
- **(bin-paths)** add executable names output by @risu729 in
[#9617](#9617)

### 🐛 Bug Fixes

- **(aqua)** preserve configured file extensions by @risu729 in
[#9611](#9611)
- **(aqua)** support registry file links by @risu729 in
[#9610](#9610)
- **(backend)** reject bare package backend names by @risu729 in
[#9608](#9608)
- **(backend)** apply inline tool option overrides by @risu729 in
[#9306](#9306)
- **(backend)** skip versions host for local tool opts by @risu729 in
[#9568](#9568)
- **(github)** chmod explicit archive bin by @risu729 in
[#9609](#9609)
- **(install)** skip remote-versions refresh in prefer-offline mode by
@jdx in [#9627](#9627)
- **(lock)** scope targets to active project root by @risu729 in
[#9319](#9319)
- **(lockfile)** respect existing platforms during auto-lock by @jdx in
[#9621](#9621)
- **(pipx)** filter yanked pypi releases by @risu729 in
[#9607](#9607)
- **(pipx)** declare python as a backend dependency by @jdx in
[#9678](#9678)
- **(schema)** update refs to $defs in mise-registry-tool.json by
@risu729 in [#9671](#9671)
- **(task)** terminate parallel siblings on failure via process groups
by @jdx in [#9655](#9655)
- **(task)** stable MISE_PROJECT_ROOT for monorepo tasks, add
MISE_MONOREPO_ROOT by @jdx in
[#9657](#9657)
- **(trust)** run enter hooks after trusting config by @risu729 in
[#9634](#9634)
- **(ui)** stop clearing screen for prompts by @jdx in
[#9619](#9619)
- use /bin/cp on macos by @pdehlke in
[#9656](#9656)

### 🚜 Refactor

- **(aqua)** store aqua var defaults as strings by @risu729 in
[#9645](#9645)
- **(config)** support structured TOML values in registry backend
options by @risu729 in [#9584](#9584)
- **(deps)** remove serde_derive dependency by @risu729 in
[#9670](#9670)
- **(deps)** remove anyhow dependency by @risu729 in
[#9661](#9661)
- **(deps)** use std::sync::LazyLock instead of once_cell::Lazy by
@risu729 in [#9668](#9668)
- **(schema)** generate task schema from mise schema by @risu729 in
[#9581](#9581)
- **(schema)** reuse task props with unevaluatedProperties by @risu729
in [#9582](#9582)
- **(schema)** reuse registry common types by @risu729 in
[#9648](#9648)
- **(schema)** reuse plugin script config by @risu729 in
[#9647](#9647)
- **(schema)** use $defs in schema files by @risu729 in
[#9646](#9646)

### 📚 Documentation

- **(node)** add tips for enabling node idiomatic by @fu050409 in
[#9675](#9675)

### 🧪 Testing

- **(cli)** remove nondeterministic tool depends assertion by @risu729
in [#9633](#9633)
- **(e2e)** pin uv to 0.11.8 around astral-sh/uv#19278 by @jdx in
[#9618](#9618)
- **(e2e)** wait for docker env cleanup by @risu729 in
[#9631](#9631)
- **(zig)** use official zig instead of mach mirror by @jdx in
[#9659](#9659)

### 📦️ Dependency Updates

- fall through to hash check when providers have no outputs by @jdx in
[#9622](#9622)
- bump Cargo.lock by @jdx in
[#9625](#9625)

### 📦 Registry

- remove registry depends by @risu729 in
[#9571](#9571)
- add code-review-graph (pipx:code-review-graph) by @chautruonglong in
[#9673](#9673)

### Chore

- **(ci)** split large registry test-tool changes by @risu729 in
[#9628](#9628)
- **(ci)** make perf script robust to runner noise by @jdx in
[#9635](#9635)
- **(ci)** skip hyperfine comments without permission by @risu729 in
[#9629](#9629)

### New Contributors

- @chautruonglong made their first contribution in
[#9673](#9673)
- @pdehlke made their first contribution in
[#9656](#9656)

## 📦 Aqua Registry Updates

### New Packages (5)

-
[`anthropics/anthropic-cli`](https://github.com/anthropics/anthropic-cli)
- [`crates.io/wasmi_cli`](https://github.com/wasmi-labs/wasmi)
- [`openclaw/gogcli`](https://github.com/openclaw/gogcli)
- `racket-lang.org/racket-minimal`
- [`runs-on/cli`](https://github.com/runs-on/cli)

### Updated Packages (13)

- [`UpCloudLtd/upcloud-cli`](https://github.com/UpCloudLtd/upcloud-cli)
- [`aristocratos/btop`](https://github.com/aristocratos/btop)
- [`dprint/dprint`](https://github.com/dprint/dprint)
- [`j178/prek`](https://github.com/j178/prek)
- [`jdx/hk`](https://github.com/jdx/hk)
- [`jdx/mise`](https://github.com/jdx/mise)
- [`jdx/usage`](https://github.com/jdx/usage)
- [`jreleaser/jreleaser`](https://github.com/jreleaser/jreleaser)
-
[`jreleaser/jreleaser/standalone`](https://github.com/jreleaser/jreleaser)
- [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
- [`suzuki-shunsuke/cmdx`](https://github.com/suzuki-shunsuke/cmdx)
- [`suzuki-shunsuke/ghir`](https://github.com/suzuki-shunsuke/ghir)
- [`twpayne/chezmoi`](https://github.com/twpayne/chezmoi)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants