Skip to content

refactor(deps): remove anyhow dependency#9661

Merged
jdx merged 3 commits intojdx:mainfrom
risu729:codex/remove-anyhow-dependency
May 7, 2026
Merged

refactor(deps): remove anyhow dependency#9661
jdx merged 3 commits intojdx:mainfrom
risu729:codex/remove-anyhow-dependency

Conversation

@risu729
Copy link
Copy Markdown
Contributor

@risu729 risu729 commented May 7, 2026

Summary

  • remove the direct anyhow dependency from the main crate
  • convert ubi errors to eyre at the backend boundary
  • keep 404 detection for try_with_v_prefix retry handling

Dependency audit

  • rg anyhow Cargo.toml src crates build.rs has no direct hits after the change
  • cargo tree -p mise --depth 1 --edges normal,build,dev no longer lists anyhow as a direct mise dependency
  • anyhow remains in Cargo.lock transitively through crates such as ubi/rattler

Verification

  • cargo check -p mise --all-targets

This PR was generated by an AI coding assistant.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Greptile Summary

This PR removes the direct anyhow dependency from the main mise crate by converting ubi library errors to eyre::Report at the backend boundary using eyre::eyre!("{e:#}"), and merges the two VerifiableError trait implementations into a single impl VerifiableError for eyre::Report.

  • static_helpers.rs: The old impl VerifiableError for anyhow::Error (with string-match-first + typed-downcast chain walk) is merged into impl VerifiableError for eyre::Report, replacing the prior eyre impl that only used typed downcasting. The into_eyre identity return is correct.
  • ubi.rs: install() return type is changed from anyhow::Result to eyre::Result; redundant .map_err(|e| eyre::eyre!(e)) wrapping at the two direct call sites is correctly removed since they're no longer converting across error types.

Confidence Score: 5/5

Safe to merge; the change is a clean dependency removal with no functional regressions beyond the string-only 404 detection for ubi errors, which was already discussed in a prior review thread.

The refactor is mechanical and well-scoped: anyhow is fully removed from imports and Cargo.toml, the two VerifiableError impls are correctly merged, and the redundant map_err wrappers are dropped now that install() returns eyre::Result directly. No new defects were introduced.

No files require special attention.

Reviews (3): Last reviewed commit: "Merge branch 'main' into codex/remove-an..." | Re-trigger Greptile

Comment thread src/backend/ubi.rs
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the anyhow dependency, transitioning the codebase to use eyre for error handling. Changes include updating dependency files, refactoring the VerifiableError trait implementation to work with eyre::Report, and updating the ubi backend's return types. A review comment suggests a more robust method for converting errors in ubi.rs to ensure the error chain is preserved rather than flattened into a string, which would maintain better diagnostic information.

Comment thread src/backend/ubi.rs
@risu729

This comment was marked as outdated.

@risu729 risu729 marked this pull request as ready for review May 7, 2026 11:15
@jdx jdx enabled auto-merge (squash) May 7, 2026 11:21
@jdx jdx merged commit f865514 into jdx:main May 7, 2026
33 checks passed
@risu729 risu729 deleted the codex/remove-anyhow-dependency branch May 7, 2026 12:13
mise-en-dev added a commit that referenced this pull request May 7, 2026
### 🚀 Features

- **(aqua)** support registry libc variants by @jdx in
[#9652](#9652)
- **(bin-paths)** add executable names output by @risu729 in
[#9617](#9617)

### 🐛 Bug Fixes

- **(aqua)** preserve configured file extensions by @risu729 in
[#9611](#9611)
- **(aqua)** support registry file links by @risu729 in
[#9610](#9610)
- **(backend)** reject bare package backend names by @risu729 in
[#9608](#9608)
- **(backend)** apply inline tool option overrides by @risu729 in
[#9306](#9306)
- **(backend)** skip versions host for local tool opts by @risu729 in
[#9568](#9568)
- **(github)** chmod explicit archive bin by @risu729 in
[#9609](#9609)
- **(install)** skip remote-versions refresh in prefer-offline mode by
@jdx in [#9627](#9627)
- **(lock)** scope targets to active project root by @risu729 in
[#9319](#9319)
- **(lockfile)** respect existing platforms during auto-lock by @jdx in
[#9621](#9621)
- **(pipx)** filter yanked pypi releases by @risu729 in
[#9607](#9607)
- **(pipx)** declare python as a backend dependency by @jdx in
[#9678](#9678)
- **(schema)** update refs to $defs in mise-registry-tool.json by
@risu729 in [#9671](#9671)
- **(task)** terminate parallel siblings on failure via process groups
by @jdx in [#9655](#9655)
- **(task)** stable MISE_PROJECT_ROOT for monorepo tasks, add
MISE_MONOREPO_ROOT by @jdx in
[#9657](#9657)
- **(trust)** run enter hooks after trusting config by @risu729 in
[#9634](#9634)
- **(ui)** stop clearing screen for prompts by @jdx in
[#9619](#9619)
- use /bin/cp on macos by @pdehlke in
[#9656](#9656)

### 🚜 Refactor

- **(aqua)** store aqua var defaults as strings by @risu729 in
[#9645](#9645)
- **(config)** support structured TOML values in registry backend
options by @risu729 in [#9584](#9584)
- **(deps)** remove serde_derive dependency by @risu729 in
[#9670](#9670)
- **(deps)** remove anyhow dependency by @risu729 in
[#9661](#9661)
- **(deps)** use std::sync::LazyLock instead of once_cell::Lazy by
@risu729 in [#9668](#9668)
- **(schema)** generate task schema from mise schema by @risu729 in
[#9581](#9581)
- **(schema)** reuse task props with unevaluatedProperties by @risu729
in [#9582](#9582)
- **(schema)** reuse registry common types by @risu729 in
[#9648](#9648)
- **(schema)** reuse plugin script config by @risu729 in
[#9647](#9647)
- **(schema)** use $defs in schema files by @risu729 in
[#9646](#9646)

### 📚 Documentation

- **(node)** add tips for enabling node idiomatic by @fu050409 in
[#9675](#9675)

### 🧪 Testing

- **(cli)** remove nondeterministic tool depends assertion by @risu729
in [#9633](#9633)
- **(e2e)** pin uv to 0.11.8 around astral-sh/uv#19278 by @jdx in
[#9618](#9618)
- **(e2e)** wait for docker env cleanup by @risu729 in
[#9631](#9631)
- **(zig)** use official zig instead of mach mirror by @jdx in
[#9659](#9659)

### 📦️ Dependency Updates

- fall through to hash check when providers have no outputs by @jdx in
[#9622](#9622)
- bump Cargo.lock by @jdx in
[#9625](#9625)

### 📦 Registry

- remove registry depends by @risu729 in
[#9571](#9571)
- add code-review-graph (pipx:code-review-graph) by @chautruonglong in
[#9673](#9673)

### Chore

- **(ci)** split large registry test-tool changes by @risu729 in
[#9628](#9628)
- **(ci)** make perf script robust to runner noise by @jdx in
[#9635](#9635)
- **(ci)** skip hyperfine comments without permission by @risu729 in
[#9629](#9629)

### New Contributors

- @chautruonglong made their first contribution in
[#9673](#9673)
- @pdehlke made their first contribution in
[#9656](#9656)

## 📦 Aqua Registry Updates

### New Packages (5)

-
[`anthropics/anthropic-cli`](https://github.com/anthropics/anthropic-cli)
- [`crates.io/wasmi_cli`](https://github.com/wasmi-labs/wasmi)
- [`openclaw/gogcli`](https://github.com/openclaw/gogcli)
- `racket-lang.org/racket-minimal`
- [`runs-on/cli`](https://github.com/runs-on/cli)

### Updated Packages (13)

- [`UpCloudLtd/upcloud-cli`](https://github.com/UpCloudLtd/upcloud-cli)
- [`aristocratos/btop`](https://github.com/aristocratos/btop)
- [`dprint/dprint`](https://github.com/dprint/dprint)
- [`j178/prek`](https://github.com/j178/prek)
- [`jdx/hk`](https://github.com/jdx/hk)
- [`jdx/mise`](https://github.com/jdx/mise)
- [`jdx/usage`](https://github.com/jdx/usage)
- [`jreleaser/jreleaser`](https://github.com/jreleaser/jreleaser)
-
[`jreleaser/jreleaser/standalone`](https://github.com/jreleaser/jreleaser)
- [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
- [`suzuki-shunsuke/cmdx`](https://github.com/suzuki-shunsuke/cmdx)
- [`suzuki-shunsuke/ghir`](https://github.com/suzuki-shunsuke/ghir)
- [`twpayne/chezmoi`](https://github.com/twpayne/chezmoi)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants