fix(ci): add missing build dependencies to e2e Docker image#8914
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the packaging/e2e/Dockerfile to include several new build dependencies: autoconf, cargo, libncurses-dev, and pkg-config. All review comments were removed as they requested the user to ensure alphabetical sorting without providing a code suggestion, and the packages are already correctly ordered. I have no feedback to provide.
Needed by openssl-sys crate to find system OpenSSL when compiling cargo crates from source (e.g. test_cargo_binstall_slow). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
06159ab to
dca8a93
Compare
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge — CI-only Dockerfile change with no application logic affected. Single-file change that adds four well-known build packages to fix verified failing tests. Packages are alphabetically ordered, the author confirmed builds pass on Bamboo, and the e2e cargo tests primarily use cargo-binstall (pre-compiled binaries), so the apt-packaged Rust version is sufficient. No P0/P1 issues found. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(ci): add pkg-config to e2e Docker im..." | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 x -- echo |
23.0 ± 0.6 | 21.5 | 25.9 | 1.00 |
mise x -- echo |
23.5 ± 0.6 | 22.2 | 25.5 | 1.02 ± 0.04 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 env |
22.5 ± 0.9 | 21.1 | 31.2 | 1.00 |
mise env |
22.9 ± 0.6 | 21.8 | 25.5 | 1.02 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 hook-env |
23.1 ± 0.5 | 22.0 | 25.2 | 1.00 |
mise hook-env |
23.7 ± 0.6 | 22.4 | 29.1 | 1.03 ± 0.04 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 ls |
20.3 ± 0.5 | 19.2 | 22.7 | 1.00 |
mise ls |
20.9 ± 0.7 | 19.9 | 30.2 | 1.03 ± 0.04 |
xtasks/test/perf
| Command | mise-2026.4.3 | mise | Variance |
|---|---|---|---|
| install (cached) | 150ms | 152ms | -1% |
| ls (cached) | 79ms | 79ms | +0% |
| bin-paths (cached) | 83ms | 83ms | +0% |
| task-ls (cached) | 829ms | 803ms | +3% |
### 🚀 Features - **(ci)** auto-convert external PRs to draft mode by @jdx in [#8896](#8896) - **(deps)** add `depends` field for user-specified tool dependencies by @cprecioso in [#8776](#8776) - **(dotnet)** support runtime-only installs by @fragon10 in [#8524](#8524) - **(npm)** apply install_before to transitive dependencies by @risu729 in [#8851](#8851) - **(task)** allow passing arguments to task dependencies via {{usage.*}} templates by @jdx in [#8893](#8893) - add options field to BackendListVersionsCtx by @esteve in [#8875](#8875) ### 🐛 Bug Fixes - **(backend)** filter PEP 440 .dev versions in fuzzy version matching by @richardthe3rd in [#8849](#8849) - **(ci)** update COPR BuildRequires rust version to match MSRV 1.88 by @jdx in [#8911](#8911) - **(ci)** add Ruby build dependencies to e2e Docker image by @jdx in [#8910](#8910) - **(ci)** add missing build dependencies to e2e Docker image by @jdx in [#8912](#8912) - **(ci)** add missing build dependencies to e2e Docker image by @jdx in [#8914](#8914) - **(ci)** use Node 24 LTS for corepack e2e test by @jdx in [#8915](#8915) - **(ci)** add libxml2 and pkg-config to e2e Docker image by @jdx in [#8917](#8917) - **(ci)** add libxml2-dev to e2e image and disable Swift SPM tests by @jdx in [#8918](#8918) - **(docs)** use sans-serif font for badges by @jdx in [#8887](#8887) - **(env)** parse --env=VALUE and -E=VALUE flag forms correctly by @jdx in [#8889](#8889) - **(exec)** use i64::from() for seccomp syscall numbers to survive autofix by @jdx in [#8882](#8882) - **(github)** preserve tool options like filter_bins when version specified via CLI by @jdx in [#8888](#8888) - **(github)** use alias-specific options when tool_alias has its own config by @jdx in [#8892](#8892) - **(install)** add locked_verify_provenance setting and detect github attestations at lock time by @jdx in [#8901](#8901) - **(lock)** prune stale version entries during filtered `mise lock <tool>` runs by @altendky in [#8599](#8599) - **(python)** use lockfile URL for precompiled installs by @hehaoqian in [#8750](#8750) - **(release)** verify all build targets succeed before releasing by @jdx in [#8886](#8886) - **(ruby)** support build revisions for precompiled binaries in mise.lock by @jdx in [#8900](#8900) - **(swift)** fall back to Ubuntu 24.04 for unsupported Ubuntu versions by @jdx in [#8916](#8916) - **(zsh)** avoid duplicate trust warning after cd by @timothysparg in [#8898](#8898) - update flake.lock and add fix for rust-bindgen to default.nix by @esteve in [#8874](#8874) - when direnv diff is empty, do not try to parse it by @yaleman in [#8857](#8857) - skip trust check for plain .tool-versions in task list by @dportalesr in [#8876](#8876) ### 🚜 Refactor - **(go)** rename go_* settings to go.* namespace by @jdbruijn in [#8598](#8598) ### 📚 Documentation - **(tasks)** clarify task_config.includes behavior by @risu729 in [#8905](#8905) ### 🧪 Testing - **(ci)** run e2e tests inside Docker containers by @jdx in [#8899](#8899) ### 📦️ Dependency Updates - bump ubi from 0.8 to 0.9 by @jdx in [#8906](#8906) - bump zip from 3 to 8 by @jdx in [#8908](#8908) - update lockfile deps (hold back rattler) by @jdx in [#8909](#8909) - update bun.lock by @jdx in [#8913](#8913) ### 📦 Registry - add turso ([github:tursodatabase/turso-cli](https://github.com/tursodatabase/turso-cli)) by @kenn in [#8884](#8884) - remove carp test by @jdx in [#8894](#8894) ### Chore - **(ci)** add workflow to warn PRs modifying vendored aqua-registry by @jdx in [#8897](#8897) - **(ci)** use github.token for draft conversion in auto-draft workflow by @jdx in [#8903](#8903) - remove deprecated settings older than 12 months by @jdx in [#8904](#8904) ### New Contributors - @dportalesr made their first contribution in [#8876](#8876) - @timothysparg made their first contribution in [#8898](#8898) - @hehaoqian made their first contribution in [#8750](#8750) - @jdbruijn made their first contribution in [#8598](#8598) - @cprecioso made their first contribution in [#8776](#8776) - @yaleman made their first contribution in [#8857](#8857) - @kenn made their first contribution in [#8884](#8884) - @fragon10 made their first contribution in [#8524](#8524) ## 📦 Aqua Registry Updates #### New Packages (6) - [`ahkohd/oyo`](https://github.com/ahkohd/oyo) - [`bellicose100xp/jiq`](https://github.com/bellicose100xp/jiq) - [`kurama/dealve-tui`](https://github.com/kurama/dealve-tui) - [`micahkepe/jsongrep`](https://github.com/micahkepe/jsongrep) - [`textfuel/lazyjira`](https://github.com/textfuel/lazyjira) - [`ubugeeei/vize`](https://github.com/ubugeeei/vize) #### Updated Packages (1) - [`sigstore/cosign`](https://github.com/sigstore/cosign)
Summary
autoconf,cargo,libncurses-dev,pkg-configto e2e Docker imagetest_cargo_*_slow: cargo not installed, pkg-config missing for openssl-systest_erlang_slow: missing autoconf and libncurses-devtest_vfox_python_slow,test_node_slow,test_gem_slow: already fixed by fix(ci): add Ruby build dependencies to e2e Docker image #8910Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk: a single additional system package in the CI/e2e container, with minimal chance of impacting runtime behavior outside image build size/time.
Overview
Ensures the e2e Docker image includes the missing build tool
pkg-config, improving CI reliability for components that compile native dependencies during end-to-end tests.Reviewed by Cursor Bugbot for commit dca8a93. Bugbot is set up for automated code reviews on this repo. Configure here.