fix(ci): update COPR BuildRequires rust version to match MSRV 1.88#8911
fix(ci): update COPR BuildRequires rust version to match MSRV 1.88#8911
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR bumps the minimum Rust version in the COPR build spec from
Confidence Score: 5/5Safe to merge — minimal one-line version bump with no logic changes. Single-line change that correctly aligns the COPR BuildRequires with the project MSRV as declared in Cargo.toml. The fix is verified against the actual rust-version field in Cargo.toml (1.88). No risk. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Cargo.toml\nrust-version = 1.88] -->|MSRV| B[COPR spec BuildRequires]
B --> C{Versions match?}
C -- Before PR: rust >= 1.85 --> D[❌ Build could fail\non Rust 1.85–1.87]
C -- After PR: rust >= 1.88 --> E[✅ Spec matches MSRV\nBuild succeeds]
Reviews (1): Last reviewed commit: "fix(ci): update COPR BuildRequires rust ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request updates the minimum Rust version requirement from 1.85 to 1.88 in the COPR build script. The reviewer suggested automating this versioning by sourcing it directly from Cargo.toml to prevent future synchronization issues and reduce manual maintenance.
| Source1: mise-vendor-%{version}.tar.gz | ||
|
|
||
| BuildRequires: rust >= 1.85 | ||
| BuildRequires: rust >= 1.88 |
There was a problem hiding this comment.
To prevent this version from becoming out of sync with Cargo.toml in the future, consider sourcing it directly from Cargo.toml at build time.
You could introduce a placeholder here, like __RUST_VERSION__, and then populate it similarly to how other placeholders like __VERSION__ are handled in this script.
For example, you could add this to the script:
# After REPO_ROOT is defined
RUST_VERSION=$(grep '^rust-version' "$REPO_ROOT/Cargo.toml" | cut -d '"' -f 2)
# In the replacement section around line 264
sed -i "s/__RUST_VERSION__/${RUST_VERSION}/g" "SPECS/${PACKAGE_NAME}.spec"This would make the build process more robust and reduce manual maintenance.
| BuildRequires: rust >= 1.88 | |
| BuildRequires: rust >= __RUST_VERSION__ |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 x -- echo |
23.4 ± 0.4 | 22.5 | 27.1 | 1.00 |
mise x -- echo |
23.8 ± 0.8 | 22.9 | 35.8 | 1.02 ± 0.04 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 env |
22.8 ± 0.5 | 21.9 | 26.4 | 1.00 |
mise env |
23.4 ± 0.5 | 22.3 | 25.7 | 1.03 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 hook-env |
23.6 ± 0.4 | 22.7 | 26.4 | 1.00 |
mise hook-env |
24.2 ± 0.5 | 23.2 | 25.8 | 1.02 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.3 ls |
20.7 ± 0.7 | 19.8 | 33.9 | 1.00 |
mise ls |
21.4 ± 0.5 | 20.2 | 25.0 | 1.03 ± 0.04 |
xtasks/test/perf
| Command | mise-2026.4.3 | mise | Variance |
|---|---|---|---|
| install (cached) | 151ms | 153ms | -1% |
| ls (cached) | 79ms | 80ms | -1% |
| bin-paths (cached) | 84ms | 85ms | -1% |
| task-ls (cached) | 805ms | 809ms | +0% |
### 🚀 Features - **(ci)** auto-convert external PRs to draft mode by @jdx in [#8896](#8896) - **(deps)** add `depends` field for user-specified tool dependencies by @cprecioso in [#8776](#8776) - **(dotnet)** support runtime-only installs by @fragon10 in [#8524](#8524) - **(npm)** apply install_before to transitive dependencies by @risu729 in [#8851](#8851) - **(task)** allow passing arguments to task dependencies via {{usage.*}} templates by @jdx in [#8893](#8893) - add options field to BackendListVersionsCtx by @esteve in [#8875](#8875) ### 🐛 Bug Fixes - **(backend)** filter PEP 440 .dev versions in fuzzy version matching by @richardthe3rd in [#8849](#8849) - **(ci)** update COPR BuildRequires rust version to match MSRV 1.88 by @jdx in [#8911](#8911) - **(ci)** add Ruby build dependencies to e2e Docker image by @jdx in [#8910](#8910) - **(ci)** add missing build dependencies to e2e Docker image by @jdx in [#8912](#8912) - **(ci)** add missing build dependencies to e2e Docker image by @jdx in [#8914](#8914) - **(ci)** use Node 24 LTS for corepack e2e test by @jdx in [#8915](#8915) - **(ci)** add libxml2 and pkg-config to e2e Docker image by @jdx in [#8917](#8917) - **(ci)** add libxml2-dev to e2e image and disable Swift SPM tests by @jdx in [#8918](#8918) - **(docs)** use sans-serif font for badges by @jdx in [#8887](#8887) - **(env)** parse --env=VALUE and -E=VALUE flag forms correctly by @jdx in [#8889](#8889) - **(exec)** use i64::from() for seccomp syscall numbers to survive autofix by @jdx in [#8882](#8882) - **(github)** preserve tool options like filter_bins when version specified via CLI by @jdx in [#8888](#8888) - **(github)** use alias-specific options when tool_alias has its own config by @jdx in [#8892](#8892) - **(install)** add locked_verify_provenance setting and detect github attestations at lock time by @jdx in [#8901](#8901) - **(lock)** prune stale version entries during filtered `mise lock <tool>` runs by @altendky in [#8599](#8599) - **(python)** use lockfile URL for precompiled installs by @hehaoqian in [#8750](#8750) - **(release)** verify all build targets succeed before releasing by @jdx in [#8886](#8886) - **(ruby)** support build revisions for precompiled binaries in mise.lock by @jdx in [#8900](#8900) - **(swift)** fall back to Ubuntu 24.04 for unsupported Ubuntu versions by @jdx in [#8916](#8916) - **(zsh)** avoid duplicate trust warning after cd by @timothysparg in [#8898](#8898) - update flake.lock and add fix for rust-bindgen to default.nix by @esteve in [#8874](#8874) - when direnv diff is empty, do not try to parse it by @yaleman in [#8857](#8857) - skip trust check for plain .tool-versions in task list by @dportalesr in [#8876](#8876) ### 🚜 Refactor - **(go)** rename go_* settings to go.* namespace by @jdbruijn in [#8598](#8598) ### 📚 Documentation - **(tasks)** clarify task_config.includes behavior by @risu729 in [#8905](#8905) ### 🧪 Testing - **(ci)** run e2e tests inside Docker containers by @jdx in [#8899](#8899) ### 📦️ Dependency Updates - bump ubi from 0.8 to 0.9 by @jdx in [#8906](#8906) - bump zip from 3 to 8 by @jdx in [#8908](#8908) - update lockfile deps (hold back rattler) by @jdx in [#8909](#8909) - update bun.lock by @jdx in [#8913](#8913) ### 📦 Registry - add turso ([github:tursodatabase/turso-cli](https://github.com/tursodatabase/turso-cli)) by @kenn in [#8884](#8884) - remove carp test by @jdx in [#8894](#8894) ### Chore - **(ci)** add workflow to warn PRs modifying vendored aqua-registry by @jdx in [#8897](#8897) - **(ci)** use github.token for draft conversion in auto-draft workflow by @jdx in [#8903](#8903) - remove deprecated settings older than 12 months by @jdx in [#8904](#8904) ### New Contributors - @dportalesr made their first contribution in [#8876](#8876) - @timothysparg made their first contribution in [#8898](#8898) - @hehaoqian made their first contribution in [#8750](#8750) - @jdbruijn made their first contribution in [#8598](#8598) - @cprecioso made their first contribution in [#8776](#8776) - @yaleman made their first contribution in [#8857](#8857) - @kenn made their first contribution in [#8884](#8884) - @fragon10 made their first contribution in [#8524](#8524) ## 📦 Aqua Registry Updates #### New Packages (6) - [`ahkohd/oyo`](https://github.com/ahkohd/oyo) - [`bellicose100xp/jiq`](https://github.com/bellicose100xp/jiq) - [`kurama/dealve-tui`](https://github.com/kurama/dealve-tui) - [`micahkepe/jsongrep`](https://github.com/micahkepe/jsongrep) - [`textfuel/lazyjira`](https://github.com/textfuel/lazyjira) - [`ubugeeei/vize`](https://github.com/ubugeeei/vize) #### Updated Packages (1) - [`sigstore/cosign`](https://github.com/sigstore/cosign)
Summary
BuildRequires: rust >= 1.85torust >= 1.88in the COPR spec template to match the project's MSRVTest plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk: a single packaging change that raises the COPR build Rust minimum version, affecting only build-time requirements.
Overview
Updates the COPR RPM spec template generated by
packaging/copr/build-copr.shto require Rust >= 1.88 (from 1.85), aligning COPR builds with the project’s MSRV.Reviewed by Cursor Bugbot for commit c10367a. Bugbot is set up for automated code reviews on this repo. Configure here.