Skip to content

fix(docs): use sans-serif font for badges#8887

Merged
jdx merged 1 commit intomainfrom
fix/docs-badge-font
Apr 4, 2026
Merged

fix(docs): use sans-serif font for badges#8887
jdx merged 1 commit intomainfrom
fix/docs-badge-font

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Apr 4, 2026

Summary

  • Badge component was inheriting the serif heading font (Cormorant Garamond) instead of the base sans-serif font (Roc Grotesk)
  • Added explicit font-family: var(--vp-font-family-base) to the .badge class

Test plan

  • Verify experimental/warning badges render in Roc Grotesk on docs pages (e.g., sandboxing, secrets)

🤖 Generated with Claude Code


Note

Low Risk
Low risk: a single CSS change that only affects badge typography in the docs theme.

Overview
Ensures docs .badge styling explicitly uses the base sans-serif font by adding font-family: var(--vp-font-family-base), preventing badges from inheriting the serif heading font.

Reviewed by Cursor Bugbot for commit a0cf680. Bugbot is set up for automated code reviews on this repo. Configure here.

The badge component was inheriting the serif heading font (Cormorant
Garamond) instead of the base sans-serif font (Roc Grotesk).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 4, 2026

Greptile Summary

This PR adds font-family: var(--vp-font-family-base) to the .badge CSS class in the VitePress theme to prevent badges from inheriting the serif heading font (Cormorant Garamond) and ensure they render in the correct sans-serif base font (Roc Grotesk).

Confidence Score: 5/5

Safe to merge — single-line CSS fix with no logic or functional risk.

The change is a one-line CSS property addition that correctly uses an existing VitePress CSS variable to override font inheritance. No logic, data, or API surface is affected.

No files require special attention.

Important Files Changed

Filename Overview
docs/.vitepress/theme/custom.css Adds font-family: var(--vp-font-family-base) to .badge class to fix font inheritance; straightforward and correct fix.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[VitePress heading styles] -->|sets font-family| B[Cormorant Garamond - serif]
    C[.badge class] -->|before fix: inherits from heading| B
    C -->|after fix: explicit override| D[var --vp-font-family-base - Roc Grotesk sans-serif]
    E[Badge renders correctly] --- D
Loading

Reviews (1): Last reviewed commit: "fix(docs): use sans-serif font for badge..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CSS for badges in the VitePress theme by explicitly setting the font family to the base theme font. A review comment suggests adding the !important flag to this declaration to ensure the font override is consistently applied when badges are nested within headings, maintaining consistency with other overrides in the stylesheet.

padding: 0.25rem 0.5rem;
font-size: 0.75rem;
font-weight: 600;
font-family: var(--vp-font-family-base);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure the font override is consistently applied even when badges are nested within headings (which use !important for their font-family on line 252), and to maintain consistency with other font overrides in this file (e.g., lines 260, 556), consider adding !important to this declaration.

Suggested change
font-family: var(--vp-font-family-base);
font-family: var(--vp-font-family-base) !important;

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2026

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.3 x -- echo 22.5 ± 0.5 21.5 24.2 1.00
mise x -- echo 23.0 ± 0.4 22.0 24.5 1.02 ± 0.03

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.3 env 21.9 ± 0.7 21.0 28.4 1.00
mise env 22.1 ± 0.3 21.3 23.8 1.01 ± 0.03

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.3 hook-env 22.6 ± 0.6 21.7 27.3 1.00
mise hook-env 22.9 ± 0.4 22.1 24.7 1.02 ± 0.03

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.4.3 ls 19.7 ± 0.3 19.0 21.3 1.00
mise ls 20.1 ± 0.4 19.4 21.5 1.02 ± 0.03

xtasks/test/perf

Command mise-2026.4.3 mise Variance
install (cached) 148ms 148ms +0%
ls (cached) 77ms 78ms -1%
bin-paths (cached) 82ms 81ms +1%
task-ls (cached) 805ms 801ms +0%

@jdx jdx merged commit 1e5633b into main Apr 4, 2026
39 checks passed
@jdx jdx deleted the fix/docs-badge-font branch April 4, 2026 13:13
jdx pushed a commit that referenced this pull request Apr 5, 2026
### 🚀 Features

- **(ci)** auto-convert external PRs to draft mode by @jdx in
[#8896](#8896)
- **(deps)** add `depends` field for user-specified tool dependencies by
@cprecioso in [#8776](#8776)
- **(dotnet)** support runtime-only installs by @fragon10 in
[#8524](#8524)
- **(npm)** apply install_before to transitive dependencies by @risu729
in [#8851](#8851)
- **(task)** allow passing arguments to task dependencies via
{{usage.*}} templates by @jdx in
[#8893](#8893)
- add options field to BackendListVersionsCtx by @esteve in
[#8875](#8875)

### 🐛 Bug Fixes

- **(backend)** filter PEP 440 .dev versions in fuzzy version matching
by @richardthe3rd in [#8849](#8849)
- **(ci)** update COPR BuildRequires rust version to match MSRV 1.88 by
@jdx in [#8911](#8911)
- **(ci)** add Ruby build dependencies to e2e Docker image by @jdx in
[#8910](#8910)
- **(ci)** add missing build dependencies to e2e Docker image by @jdx in
[#8912](#8912)
- **(ci)** add missing build dependencies to e2e Docker image by @jdx in
[#8914](#8914)
- **(ci)** use Node 24 LTS for corepack e2e test by @jdx in
[#8915](#8915)
- **(ci)** add libxml2 and pkg-config to e2e Docker image by @jdx in
[#8917](#8917)
- **(ci)** add libxml2-dev to e2e image and disable Swift SPM tests by
@jdx in [#8918](#8918)
- **(docs)** use sans-serif font for badges by @jdx in
[#8887](#8887)
- **(env)** parse --env=VALUE and -E=VALUE flag forms correctly by @jdx
in [#8889](#8889)
- **(exec)** use i64::from() for seccomp syscall numbers to survive
autofix by @jdx in [#8882](#8882)
- **(github)** preserve tool options like filter_bins when version
specified via CLI by @jdx in
[#8888](#8888)
- **(github)** use alias-specific options when tool_alias has its own
config by @jdx in [#8892](#8892)
- **(install)** add locked_verify_provenance setting and detect github
attestations at lock time by @jdx in
[#8901](#8901)
- **(lock)** prune stale version entries during filtered `mise lock
<tool>` runs by @altendky in
[#8599](#8599)
- **(python)** use lockfile URL for precompiled installs by @hehaoqian
in [#8750](#8750)
- **(release)** verify all build targets succeed before releasing by
@jdx in [#8886](#8886)
- **(ruby)** support build revisions for precompiled binaries in
mise.lock by @jdx in [#8900](#8900)
- **(swift)** fall back to Ubuntu 24.04 for unsupported Ubuntu versions
by @jdx in [#8916](#8916)
- **(zsh)** avoid duplicate trust warning after cd by @timothysparg in
[#8898](#8898)
- update flake.lock and add fix for rust-bindgen to default.nix by
@esteve in [#8874](#8874)
- when direnv diff is empty, do not try to parse it by @yaleman in
[#8857](#8857)
- skip trust check for plain .tool-versions in task list by @dportalesr
in [#8876](#8876)

### 🚜 Refactor

- **(go)** rename go_* settings to go.* namespace by @jdbruijn in
[#8598](#8598)

### 📚 Documentation

- **(tasks)** clarify task_config.includes behavior by @risu729 in
[#8905](#8905)

### 🧪 Testing

- **(ci)** run e2e tests inside Docker containers by @jdx in
[#8899](#8899)

### 📦️ Dependency Updates

- bump ubi from 0.8 to 0.9 by @jdx in
[#8906](#8906)
- bump zip from 3 to 8 by @jdx in
[#8908](#8908)
- update lockfile deps (hold back rattler) by @jdx in
[#8909](#8909)
- update bun.lock by @jdx in
[#8913](#8913)

### 📦 Registry

- add turso
([github:tursodatabase/turso-cli](https://github.com/tursodatabase/turso-cli))
by @kenn in [#8884](#8884)
- remove carp test by @jdx in
[#8894](#8894)

### Chore

- **(ci)** add workflow to warn PRs modifying vendored aqua-registry by
@jdx in [#8897](#8897)
- **(ci)** use github.token for draft conversion in auto-draft workflow
by @jdx in [#8903](#8903)
- remove deprecated settings older than 12 months by @jdx in
[#8904](#8904)

### New Contributors

- @dportalesr made their first contribution in
[#8876](#8876)
- @timothysparg made their first contribution in
[#8898](#8898)
- @hehaoqian made their first contribution in
[#8750](#8750)
- @jdbruijn made their first contribution in
[#8598](#8598)
- @cprecioso made their first contribution in
[#8776](#8776)
- @yaleman made their first contribution in
[#8857](#8857)
- @kenn made their first contribution in
[#8884](#8884)
- @fragon10 made their first contribution in
[#8524](#8524)

## 📦 Aqua Registry Updates

#### New Packages (6)

- [`ahkohd/oyo`](https://github.com/ahkohd/oyo)
- [`bellicose100xp/jiq`](https://github.com/bellicose100xp/jiq)
- [`kurama/dealve-tui`](https://github.com/kurama/dealve-tui)
- [`micahkepe/jsongrep`](https://github.com/micahkepe/jsongrep)
- [`textfuel/lazyjira`](https://github.com/textfuel/lazyjira)
- [`ubugeeei/vize`](https://github.com/ubugeeei/vize)

#### Updated Packages (1)

- [`sigstore/cosign`](https://github.com/sigstore/cosign)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant