chore: replace gen-release-notes script with communique#8289
Conversation
Summary of ChangesHello @jdx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's release note generation process by replacing a custom bash script with the dedicated Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request replaces the custom gen-release-notes bash script with communique, a dedicated tool for generating AI-editorialized release notes. The changes include adding a communique.toml configuration file, integrating communique as a tool in mise.toml and mise.lock, and removing the old script and its associated documentation. This is a positive change that improves maintainability by replacing a custom script with a specialized tool. The implementation appears correct and consistent across all modified files.
The pull request description mentions changes to a release workflow file to incorporate communique. However, this file was not included in the provided diffs, so I was unable to review those specific changes. Assuming the workflow correctly uses communique with the described fallback mechanism, this PR is a solid improvement.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6522e6e to
c584031
Compare
There was a problem hiding this comment.
Pull request overview
This PR replaces a custom bash script (xtasks/gen-release-notes) that used the Claude Code CLI with communique, a purpose-built tool for AI-editorialized release notes. The change simplifies the release workflow by removing the need for npm-based Claude Code installation and consolidates the release note generation into a single tool.
Changes:
- Removed custom
gen-release-notesbash script and its npm dependency on Claude Code CLI - Added communique as a mise tool dependency with project-specific configuration
- Simplified GitHub release workflow to create draft releases with git-cliff, then enhance with communique
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| xtasks/gen-release-notes | Deleted custom bash script that generated release notes via Claude Code CLI |
| tasks.md | Removed auto-generated documentation for the deleted gen-release-notes task |
| mise.toml | Added communique as a tool dependency |
| mise.lock | Locked communique to version 0.1.8 with github:jdx/communique backend |
| communique.toml | Added configuration with mise project context and emoji=false default |
| .github/workflows/release.yml | Simplified workflow: removed Claude Code CLI installation, simplified release creation with git-cliff fallback, added communique enhancement step with continue-on-error |
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:380
- The PR description states the workflow "creates draft release with git-cliff notes, then enhances with communique", but the actual implementation has the "Enhance release notes" step positioned after the "Publish GitHub Release" step. This means the release is already published (no longer a draft) before communique runs.
While GitHub's API does allow editing published releases, the more natural flow would be to enhance the draft before publishing it. Consider moving the "Enhance release notes" step to run after "Create Draft GitHub Release" but before "Publish GitHub Release" to align with the intended workflow described in the PR.
run: mise x -- scripts/publish-release.sh
env:
CLOUDFLARE_ACCESS_KEY_ID: ${{ secrets.CLOUDFLARE_ACCESS_KEY_ID }}
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_TOKEN }}
CLOUDFLARE_SECRET_ACCESS_KEY: ${{ secrets.CLOUDFLARE_SECRET_ACCESS_KEY }}
- name: Publish GitHub Release
if: startsWith(github.ref, 'refs/tags/v') && steps.check-release.outputs.exists != 'true'
.github/workflows/release.yml:380
- The old workflow included logic to append the "📦 Aqua Registry Updates" section from CHANGELOG.md to the release notes, with a comment explaining "LLM doesn't see it". This section is generated separately by scripts/gen-aqua-changelog.sh and added to CHANGELOG.md, but not present in git commit messages.
With the new communique-based approach, this Aqua section will likely not be included in the GitHub release notes unless communique has access to and reads from CHANGELOG.md. If this section should continue to be part of release notes, consider either:
- Adding a step to append the Aqua section after communique generates the notes, or
- Verifying that communique reads from CHANGELOG.md and includes this section
run: mise x -- scripts/publish-release.sh
env:
CLOUDFLARE_ACCESS_KEY_ID: ${{ secrets.CLOUDFLARE_ACCESS_KEY_ID }}
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_TOKEN }}
CLOUDFLARE_SECRET_ACCESS_KEY: ${{ secrets.CLOUDFLARE_SECRET_ACCESS_KEY }}
- name: Publish GitHub Release
if: startsWith(github.ref, 'refs/tags/v') && steps.check-release.outputs.exists != 'true'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 x -- echo |
23.6 ± 0.5 | 22.3 | 26.0 | 1.00 |
mise x -- echo |
24.0 ± 1.1 | 23.1 | 38.7 | 1.02 ± 0.05 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 env |
22.9 ± 1.3 | 21.7 | 41.6 | 1.00 |
mise env |
23.1 ± 0.8 | 21.9 | 28.1 | 1.01 ± 0.07 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 hook-env |
23.1 ± 0.4 | 22.3 | 25.8 | 1.00 ± 0.02 |
mise hook-env |
23.0 ± 0.3 | 22.4 | 25.6 | 1.00 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 ls |
20.3 ± 0.3 | 19.8 | 21.5 | 1.00 |
mise ls |
20.6 ± 0.4 | 19.8 | 22.1 | 1.01 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.2.17 | mise | Variance |
|---|---|---|---|
| install (cached) | 124ms | 124ms | +0% |
| ls (cached) | 76ms | 76ms | +0% |
| bin-paths (cached) | 80ms | 80ms | +0% |
| task-ls (cached) | 784ms | 790ms | +0% |
…cation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
### 🚀 Features - **(install)** auto-lock all platforms after tool installation by @jdx in [#8277](#8277) ### 🐛 Bug Fixes - **(config)** respect --yes flag for config trust prompts by @jdx in [#8288](#8288) - **(exec)** strip shims from PATH on Unix to prevent infinite recursion by @jdx in [#8276](#8276) - **(install)** validate --locked before --dry-run short-circuit by @altendky in [#8290](#8290) - **(release)** refresh PATH after mise up in release-plz by @jdx in [#8292](#8292) - **(schema)** replace unevaluatedProperties with additionalProperties by @jdx in [#8285](#8285) - **(task)** avoid duplicated stderr on task failure in replacing mode by @jdx in [#8275](#8275) - **(task)** use process groups to kill child process trees on Unix by @jdx in [#8279](#8279) - **(task)** run depends_post tasks even when parent task fails by @jdx in [#8274](#8274) - **(task)** suggest similar commands when mistyping a CLI subcommand by @jdx in [#8286](#8286) - **(task)** execute monorepo subdirectory prepare steps from root by @jdx in [#8291](#8291) - **(upgrade)** don't force-reinstall already installed versions by @jdx in [#8282](#8282) - **(watch)** restore terminal state after watchexec exits by @jdx in [#8273](#8273) ### 📚 Documentation - clarify that MISE_CEILING_PATHS excludes the ceiling directory itself by @jdx in [#8283](#8283) ### Chore - replace gen-release-notes script with communique by @jdx in [#8289](#8289) ### New Contributors - @altendky made their first contribution in [#8290](#8290) ## 📦 Aqua Registry Updates #### New Packages (4) - [`Skarlso/crd-to-sample-yaml`](https://github.com/Skarlso/crd-to-sample-yaml) - [`kunobi-ninja/kunobi-releases`](https://github.com/kunobi-ninja/kunobi-releases) - [`swanysimon/markdownlint-rs`](https://github.com/swanysimon/markdownlint-rs) - [`tmux/tmux-builds`](https://github.com/tmux/tmux-builds) #### Updated Packages (2) - [`firecow/gitlab-ci-local`](https://github.com/firecow/gitlab-ci-local) - [`k1LoW/runn`](https://github.com/k1LoW/runn)
## [2026.2.18](https://github.com/jdx/mise/compare/v2026.2.17..v2026.2.18) - 2026-02-21 ### 🚀 Features - **(install)** auto-lock all platforms after tool installation by @jdx in [#8277](jdx/mise#8277) ### 🐛 Bug Fixes - **(config)** respect --yes flag for config trust prompts by @jdx in [#8288](jdx/mise#8288) - **(exec)** strip shims from PATH on Unix to prevent infinite recursion by @jdx in [#8276](jdx/mise#8276) - **(install)** validate --locked before --dry-run short-circuit by @altendky in [#8290](jdx/mise#8290) - **(release)** refresh PATH after mise up in release-plz by @jdx in [#8292](jdx/mise#8292) - **(schema)** replace unevaluatedProperties with additionalProperties by @jdx in [#8285](jdx/mise#8285) - **(task)** avoid duplicated stderr on task failure in replacing mode by @jdx in [#8275](jdx/mise#8275) - **(task)** use process groups to kill child process trees on Unix by @jdx in [#8279](jdx/mise#8279) - **(task)** run depends_post tasks even when parent task fails by @jdx in [#8274](jdx/mise#8274) - **(task)** suggest similar commands when mistyping a CLI subcommand by @jdx in [#8286](jdx/mise#8286) - **(task)** execute monorepo subdirectory prepare steps from root by @jdx in [#8291](jdx/mise#8291) - **(upgrade)** don't force-reinstall already installed versions by @jdx in [#8282](jdx/mise#8282) - **(watch)** restore terminal state after watchexec exits by @jdx in [#8273](jdx/mise#8273) ### 📚 Documentation - clarify that MISE_CEILING_PATHS excludes the ceiling directory itself by @jdx in [#8283](jdx/mise#8283) ### Chore - replace gen-release-notes script with communique by @jdx in [#8289](jdx/mise#8289) ### New Contributors - @altendky made their first contribution in [#8290](jdx/mise#8290) ### 📦 Aqua Registry Updates #### New Packages (4) - [`Skarlso/crd-to-sample-yaml`](https://github.com/Skarlso/crd-to-sample-yaml) - [`kunobi-ninja/kunobi-releases`](https://github.com/kunobi-ninja/kunobi-releases) - [`swanysimon/markdownlint-rs`](https://github.com/swanysimon/markdownlint-rs) - [`tmux/tmux-builds`](https://github.com/tmux/tmux-builds) #### Updated Packages (2) - [`firecow/gitlab-ci-local`](https://github.com/firecow/gitlab-ci-local) - [`k1LoW/runn`](https://github.com/k1LoW/runn) ## [2026.2.17](https://github.com/jdx/mise/compare/v2026.2.16..v2026.2.17) - 2026-02-19 ### 🚀 Features - **(prepare)** update mtime of outputs after command is run by @halms in [#8243](jdx/mise#8243) ### 🐛 Bug Fixes - **(install)** use backend bin paths for per-tool postinstall hooks by @jdx in [#8234](jdx/mise#8234) - **(use)** write to config.toml instead of config.local.toml by @jdx in [#8240](jdx/mise#8240) - default legacy .mise.backend installs to non-explicit by @jean-humann in [#8245](jdx/mise#8245) ### 🚜 Refactor - **(config)** consolidate flat task_* settings into nested task.* by @jdx in [#8239](jdx/mise#8239) ### Chore - **(prepare)** refactor common code into ProviderBase by @halms in [#8246](jdx/mise#8246) ### 📦 Aqua Registry Updates #### Updated Packages (1) - [`namespacelabs/foundation/nsc`](https://github.com/namespacelabs/foundation/nsc)
## Summary - Replaces the custom `gen-release-notes` bash script (which shelled out to the Claude Code CLI) with [communique](https://github.com/jdx/communique), a purpose-built tool for AI-editorialized release notes - Adds `communique.toml` with project context and `emoji = false` default - Simplifies the release workflow: creates draft release with git-cliff notes, then enhances with `communique generate --github-release` (with `continue-on-error: true` so git-cliff content remains as fallback) ## Test plan - [ ] Verify `mise install` picks up communique - [ ] Test locally with `communique generate v2026.2.17 --dry-run` to confirm it generates notes for a past release - [ ] Review workflow changes to confirm the fallback pattern is correct 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Changes are limited to the release workflow and dev tooling; main risk is misconfigured CI causing release-note generation or draft release creation to fail/fallback. > > **Overview** > Release automation now generates draft GitHub release notes via `communique generate` (using `ANTHROPIC_API_KEY`), derives `RELEASE_TITLE` from the first line, and falls back to `git cliff` when `communique` fails. > > The custom `xtasks/gen-release-notes` script and its `tasks.md` docs are removed, and `communique` is added to `mise.toml`/`mise.lock` along with a new `communique.toml` configuration (project context, `emoji = false`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 470f4f1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
### 🚀 Features - **(install)** auto-lock all platforms after tool installation by @jdx in [jdx#8277](jdx#8277) ### 🐛 Bug Fixes - **(config)** respect --yes flag for config trust prompts by @jdx in [jdx#8288](jdx#8288) - **(exec)** strip shims from PATH on Unix to prevent infinite recursion by @jdx in [jdx#8276](jdx#8276) - **(install)** validate --locked before --dry-run short-circuit by @altendky in [jdx#8290](jdx#8290) - **(release)** refresh PATH after mise up in release-plz by @jdx in [jdx#8292](jdx#8292) - **(schema)** replace unevaluatedProperties with additionalProperties by @jdx in [jdx#8285](jdx#8285) - **(task)** avoid duplicated stderr on task failure in replacing mode by @jdx in [jdx#8275](jdx#8275) - **(task)** use process groups to kill child process trees on Unix by @jdx in [jdx#8279](jdx#8279) - **(task)** run depends_post tasks even when parent task fails by @jdx in [jdx#8274](jdx#8274) - **(task)** suggest similar commands when mistyping a CLI subcommand by @jdx in [jdx#8286](jdx#8286) - **(task)** execute monorepo subdirectory prepare steps from root by @jdx in [jdx#8291](jdx#8291) - **(upgrade)** don't force-reinstall already installed versions by @jdx in [jdx#8282](jdx#8282) - **(watch)** restore terminal state after watchexec exits by @jdx in [jdx#8273](jdx#8273) ### 📚 Documentation - clarify that MISE_CEILING_PATHS excludes the ceiling directory itself by @jdx in [jdx#8283](jdx#8283) ### Chore - replace gen-release-notes script with communique by @jdx in [jdx#8289](jdx#8289) ### New Contributors - @altendky made their first contribution in [jdx#8290](jdx#8290) ## 📦 Aqua Registry Updates #### New Packages (4) - [`Skarlso/crd-to-sample-yaml`](https://github.com/Skarlso/crd-to-sample-yaml) - [`kunobi-ninja/kunobi-releases`](https://github.com/kunobi-ninja/kunobi-releases) - [`swanysimon/markdownlint-rs`](https://github.com/swanysimon/markdownlint-rs) - [`tmux/tmux-builds`](https://github.com/tmux/tmux-builds) #### Updated Packages (2) - [`firecow/gitlab-ci-local`](https://github.com/firecow/gitlab-ci-local) - [`k1LoW/runn`](https://github.com/k1LoW/runn)
Summary
gen-release-notesbash script (which shelled out to the Claude Code CLI) with communique, a purpose-built tool for AI-editorialized release notescommunique.tomlwith project context andemoji = falsedefaultcommunique generate --github-release(withcontinue-on-error: trueso git-cliff content remains as fallback)Test plan
mise installpicks up communiquecommunique generate v2026.2.17 --dry-runto confirm it generates notes for a past release🤖 Generated with Claude Code
Note
Low Risk
Changes are limited to the release workflow and dev tooling; main risk is misconfigured CI causing release-note generation or draft release creation to fail/fallback.
Overview
Release automation now generates draft GitHub release notes via
communique generate(usingANTHROPIC_API_KEY), derivesRELEASE_TITLEfrom the first line, and falls back togit cliffwhencommuniquefails.The custom
xtasks/gen-release-notesscript and itstasks.mddocs are removed, andcommuniqueis added tomise.toml/mise.lockalong with a newcommunique.tomlconfiguration (project context,emoji = false).Written by Cursor Bugbot for commit 470f4f1. This will update automatically on new commits. Configure here.