Conversation
Summary of ChangesHello @mise-en-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine release chore, advancing the project version to Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request performs a routine release bump to version 2026.2.18, including updates to the Aqua registry. I have identified a few issues in the Aqua registry configurations for firecow/gitlab-ci-local and tmux/tmux-builds that could lead to installation failures on certain platforms due to incorrect binary source paths and architecture replacements.
| - version_constraint: "true" | ||
| asset: gitlab-ci-local-{{.OS}}-{{.Arch}}.{{.Format}} | ||
| format: tar.gz | ||
| windows_arm_emulation: true | ||
| overrides: | ||
| - goos: windows | ||
| format: zip |
There was a problem hiding this comment.
The src path inherited from the top-level files definition ({{.AssetWithoutExt}}) is incorrect for the new tar.gz assets. For an asset like gitlab-ci-local-linux-amd64.tar.gz, AssetWithoutExt would be gitlab-ci-local-linux-amd64, but the binary inside the archive is simply named gitlab-ci-local. This will cause installation to fail. Overriding the files entry to use the default src (which matches the name) fixes this. I've also added rosetta2: true and complete_windows_ext: true for better cross-platform compatibility.
- version_constraint: "true"
asset: gitlab-ci-local-{{.OS}}-{{.Arch}}.{{.Format}}
format: tar.gz
files:
- name: gitlab-ci-local
rosetta2: true
windows_arm_emulation: true
complete_windows_ext: true
overrides:
- goos: windows
format: zip| - version_constraint: "true" | ||
| asset: tmux-{{trimV .Version}}-{{.OS}}-{{.Arch}}.{{.Format}} | ||
| format: tar.gz | ||
| replacements: | ||
| amd64: x86_64 | ||
| darwin: macos |
There was a problem hiding this comment.
The global replacements for amd64: x86_64 will break installations on Linux amd64, as the assets for Linux use the amd64 suffix (e.g., tmux-3.5a-linux-amd64.tar.gz), while only macOS assets use x86_64. Moving the replacements into a darwin override ensures the correct asset is picked for each platform. I've also added rosetta2: true for macOS Silicon users.
- version_constraint: "true"
asset: tmux-{{trimV .Version}}-{{.OS}}-{{.Arch}}.{{.Format}}
format: tar.gz
rosetta2: true
overrides:
- goos: darwin
replacements:
darwin: macos
amd64: x86_64
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 x -- echo |
22.9 ± 0.5 | 22.1 | 24.4 | 1.00 |
mise x -- echo |
24.1 ± 0.5 | 23.2 | 25.8 | 1.05 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 env |
22.5 ± 0.7 | 21.7 | 28.5 | 1.00 |
mise env |
22.8 ± 0.5 | 21.8 | 24.8 | 1.01 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 hook-env |
22.9 ± 0.6 | 22.3 | 32.5 | 1.00 |
mise hook-env |
23.2 ± 0.3 | 22.5 | 25.4 | 1.01 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.17 ls |
20.5 ± 0.2 | 19.9 | 21.3 | 1.00 |
mise ls |
20.8 ± 0.3 | 20.2 | 22.0 | 1.02 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.2.17 | mise | Variance |
|---|---|---|---|
| install (cached) | 125ms | 127ms | -1% |
| ls (cached) | 77ms | 77ms | +0% |
| bin-paths (cached) | 80ms | 81ms | -1% |
| task-ls (cached) | 2717ms | ✅ 792ms | +243% |
✅ Performance improvement: task-ls cached is 243%
753aff9 to
85bbb2d
Compare
### 🚀 Features - **(install)** auto-lock all platforms after tool installation by @jdx in [jdx#8277](jdx#8277) ### 🐛 Bug Fixes - **(config)** respect --yes flag for config trust prompts by @jdx in [jdx#8288](jdx#8288) - **(exec)** strip shims from PATH on Unix to prevent infinite recursion by @jdx in [jdx#8276](jdx#8276) - **(install)** validate --locked before --dry-run short-circuit by @altendky in [jdx#8290](jdx#8290) - **(release)** refresh PATH after mise up in release-plz by @jdx in [jdx#8292](jdx#8292) - **(schema)** replace unevaluatedProperties with additionalProperties by @jdx in [jdx#8285](jdx#8285) - **(task)** avoid duplicated stderr on task failure in replacing mode by @jdx in [jdx#8275](jdx#8275) - **(task)** use process groups to kill child process trees on Unix by @jdx in [jdx#8279](jdx#8279) - **(task)** run depends_post tasks even when parent task fails by @jdx in [jdx#8274](jdx#8274) - **(task)** suggest similar commands when mistyping a CLI subcommand by @jdx in [jdx#8286](jdx#8286) - **(task)** execute monorepo subdirectory prepare steps from root by @jdx in [jdx#8291](jdx#8291) - **(upgrade)** don't force-reinstall already installed versions by @jdx in [jdx#8282](jdx#8282) - **(watch)** restore terminal state after watchexec exits by @jdx in [jdx#8273](jdx#8273) ### 📚 Documentation - clarify that MISE_CEILING_PATHS excludes the ceiling directory itself by @jdx in [jdx#8283](jdx#8283) ### Chore - replace gen-release-notes script with communique by @jdx in [jdx#8289](jdx#8289) ### New Contributors - @altendky made their first contribution in [jdx#8290](jdx#8290) ## 📦 Aqua Registry Updates #### New Packages (4) - [`Skarlso/crd-to-sample-yaml`](https://github.com/Skarlso/crd-to-sample-yaml) - [`kunobi-ninja/kunobi-releases`](https://github.com/kunobi-ninja/kunobi-releases) - [`swanysimon/markdownlint-rs`](https://github.com/swanysimon/markdownlint-rs) - [`tmux/tmux-builds`](https://github.com/tmux/tmux-builds) #### Updated Packages (2) - [`firecow/gitlab-ci-local`](https://github.com/firecow/gitlab-ci-local) - [`k1LoW/runn`](https://github.com/k1LoW/runn)
🚀 Features
🐛 Bug Fixes
📚 Documentation
Chore
New Contributors
📦 Aqua Registry Updates
New Packages (4)
Skarlso/crd-to-sample-yamlkunobi-ninja/kunobi-releasesswanysimon/markdownlint-rstmux/tmux-buildsUpdated Packages (2)
firecow/gitlab-ci-localk1LoW/runn