fix(ci): retry lint step to handle transient pkl fetch failures#341
Merged
Conversation
The hk lint tool fetches its pkl config from GitHub releases, which can intermittently return 502 errors. Wrap in nick-fields/retry like the bats tests already use. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Greptile SummaryThis PR wraps the
Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CI: ci-other job] --> B[Run tests - cargo test]
B --> C{Check formatting<br/>nick-fields/retry v3<br/>max_attempts: 3<br/>timeout: 5 min}
C -->|attempt succeeds| D[Run clippy]
C -->|attempt fails, attempts remaining| C
C -->|all 3 attempts fail| E[Job fails]
D --> F[Job passes]
Last reviewed commit: 0b79f3a |
Merged
jdx
pushed a commit
that referenced
this pull request
Mar 9, 2026
### 🚀 Features - **(cloudflare)** add Cloudflare API token lease backend by [@jdx](https://github.com/jdx) in [#335](#335) - **(fido2)** bump demand to v2, mask PIN during typing by [@jdx](https://github.com/jdx) in [#334](#334) - **(init)** add -f as short alias for --force by [@jdx](https://github.com/jdx) in [#329](#329) - **(lease)** add --all flag, default to creating all leases by [@jdx](https://github.com/jdx) in [#337](#337) - **(lease)** add GitHub App installation token lease backend by [@jdx](https://github.com/jdx) in [#342](#342) ### 🐛 Bug Fixes - **(config)** fix directory locations to follow XDG spec by [@jdx](https://github.com/jdx) in [#336](#336) - **(exec)** use unix exec and exit silently on subprocess failure by [@jdx](https://github.com/jdx) in [#339](#339) - **(fido2)** remove duplicate touch prompt by [@jdx](https://github.com/jdx) in [#332](#332) - **(set)** write to lowest-priority existing config file by [@jdx](https://github.com/jdx) in [#331](#331) - **(tui)** skip providers requiring interactive auth by [@jdx](https://github.com/jdx) in [#333](#333) ### 🛡️ Security - **(ci)** retry lint step to handle transient pkl fetch failures by [@jdx](https://github.com/jdx) in [#341](#341) - **(mcp)** add MCP server for secret-gated AI agent access by [@jdx](https://github.com/jdx) in [#343](#343) - add guide for fnox sync by [@jdx](https://github.com/jdx) in [#328](#328) ### 🔍 Other Changes - share Rust cache across CI jobs by [@jdx](https://github.com/jdx) in [#340](#340)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mise run lint) step innick-fields/retrywith 3 attempts, matching the existing retry pattern used for bats testsContext
https://github.com/jdx/fnox/actions/runs/22832770600/job/66223824636
Test plan
🤖 Generated with Claude Code
Note
Low Risk
CI-only change that alters retry behavior for linting; no production code paths or security-sensitive logic are affected.
Overview
Improves CI resilience by wrapping the
Check formattingstep (mise run lint) innick-fields/retrywith a 5-minute timeout and up to 3 attempts, matching the retry behavior already used elsewhere in the workflow.Written by Cursor Bugbot for commit 0b79f3a. This will update automatically on new commits. Configure here.