Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the fnox set command's behavior by introducing a more sophisticated mechanism for determining where configuration values should be written. Instead of a fixed target, the command now dynamically identifies the most appropriate existing local configuration file based on a defined priority, improving flexibility and user experience, especially in projects utilizing fnox.local.toml for environment-specific settings.

Highlights

• Config File Selection: The fnox set command now intelligently selects the lowest-priority existing configuration file in the current directory for writing, rather than defaulting to fnox.toml.
• fnox.local.toml Preference: If only fnox.local.toml exists, secrets are now written to it, preventing the creation of an unnecessary fnox.toml.
• fnox.toml Priority: When both fnox.toml and fnox.local.toml are present, fnox set correctly targets fnox.toml as the lowest priority.
• Fallback Behavior: If no configuration files exist, fnox set will fall back to creating and writing to fnox.toml.
• New Helper Function: A find_local_config() helper function was introduced in config.rs to encapsulate this logic for reuse.

Greptile Summary

This PR fixes fnox set so it writes to the lowest-priority existing config file in the current directory instead of always targeting fnox.toml. It introduces config::DEFAULT_CONFIG_FILENAME (eliminating the hardcoded-string duplication risk) and a new config::find_local_config() helper that encapsulates the selection logic with 11 unit tests and 3 new bats integration tests.

Key behavioral changes:

• When only fnox.local.toml exists, secrets are now written there instead of creating a new fnox.toml
• When both fnox.toml and fnox.local.toml exist, fnox.toml (lowest priority) is chosen
• When --profile staging is active and fnox.staging.toml exists, the profile-specific file is preferred
• When a non-default profile is active and no profile-specific file exists, fnox.local.toml is deliberately skipped to prevent profile-scoped secrets from landing silently in a gitignored file

All issues raised in prior review rounds have been addressed: the hardcoded sentinel string is replaced with a shared constant, redundant re-checks of profile-specific files in the fallback are eliminated, and profile secrets are no longer silently routed to fnox.local.toml.

Confidence Score: 4/5

• PR is safe to merge; the write-target selection logic is well-reasoned and covered by unit + integration tests.
• All six issues from previous review rounds are addressed. The new find_local_config logic is correct for all tested scenarios, and the unit tests cover the edge cases (no files, base only, local only, both, dotfile, profile with/without base, profile skips local). The one known remaining limitation—--config fnox.toml explicitly typed by the user is still indistinguishable from the CLI default—is a pre-existing structural constraint of clap's PathBuf default handling and does not introduce a regression compared to the prior behavior.
• No files require special attention; the core logic in src/config.rs has thorough unit test coverage.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["fnox set KEY val"] --> B{is --global?}
    B -- yes --> C[Write to global config path]
    B -- no --> D{cli.config == DEFAULT_CONFIG_FILENAME?}
    D -- no --> E["Write to current_dir.join(cli.config)"]
    D -- yes --> F["find_local_config(current_dir, profile)"]
    F --> G{Non-default profile?}
    G -- yes --> H{fnox.PROFILE.toml or .fnox.PROFILE.toml exists?}
    H -- yes --> I[Return profile-specific file]
    H -- no --> J
    G -- no --> J{fnox.toml or .fnox.toml exists?}
    J -- yes --> K[Return base file - lowest priority]
    J -- no --> L{is_profiled?}
    L -- yes --> M[Return fnox.toml - new file]
    L -- no --> N{fnox.local.toml or .fnox.local.toml exists?}
    N -- yes --> O[Return local file]
    N -- no --> M

_{Last reviewed commit: bc2d3ec}