Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the stability and user experience of the fnox Text User Interface (TUI) by preventing conflicts with authentication providers that demand interactive user input. It establishes a clear mechanism for providers to declare their interactive requirements and ensures that such providers are gracefully bypassed when the application is running in a non-interactive TUI environment. This change avoids display corruption and hangs, guiding users to the appropriate fnox exec command for operations requiring physical interaction.

Highlights

• Provider Trait Enhancement: Introduced a new requires_interactive_auth() method to the Provider trait, which defaults to false.
• Interactive Provider Identification: Configured FIDO2 and YubiKey providers to return true for requires_interactive_auth(), indicating their need for physical user interaction.
• Non-Interactive Context Flag: Implemented a non_interactive flag that is set to true upon TUI startup, marking the environment as non-interactive.
• Secret Resolution Logic: Modified the secret resolution process to skip providers that require interactive authentication when operating in a non-interactive TUI context, providing an informative error message.
• TUI Stability Improvement: Addressed potential TUI display corruption and application hangs that could occur due to interactive authentication prompts from providers.

Greptile Summary

This PR introduces a non_interactive flag for the TUI to prevent providers requiring physical interaction (FIDO2, YubiKey) from hanging or corrupting the display. The implementation is solid:

• Atomic ordering (Release/Acquire): Correctly implemented for cross-thread visibility.
• Code generation approach: Exhaustively generates a compile-time-checked match for requires_interactive_auth() from provider TOML files—avoids magic strings and ensures all variants are covered.
• Batch handling: Correctly applies per-secret if_missing policy (mirroring the ProviderNotConfigured pattern), preventing one provider's failure from silencing other providers at the same resolution level.
• Non-interactive checks placed correctly: Guards in both single-secret (try_get_secret) and provider-resolution (resolve_secret_ref) paths happen before provider instantiation, avoiding unnecessary work.

One remaining issue: prompt_and_run_auth in src/auth_prompt.rs has no is_non_interactive() guard. If any non-FIDO2 provider (e.g., 1Password) fails with an auth error in the TUI, it will still call eprintln!() and render demand::Confirm, corrupting the display—the exact problem this PR aims to solve.

Confidence Score: 3/5

• Safe for FIDO2/YubiKey skipping, but TUI can still be corrupted by auth errors from other providers.
• The core logic for skipping interactive providers in batch and single-secret paths is correct, with proper per-secret if_missing handling. Atomic ordering and code generation are sound. However, prompt_and_run_auth lacks an is_non_interactive() guard, meaning non-FIDO2 providers that fail with auth errors can still write to stderr and render prompts, corrupting the TUI display—the exact problem this PR aims to solve. This is a concrete bug but isolated to one function with a straightforward fix.
• src/auth_prompt.rs — needs is_non_interactive() guard in prompt_and_run_auth to prevent TUI corruption from any auth-error-throwing provider.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[TUI starts\nset_non_interactive true] --> B[resolve_secrets called]
    B --> C{Provider-backed\nor no-provider?}
    C -->|Provider-backed| D[resolve_provider_batch]
    C -->|No-provider| E[resolve_secret\ntry_get_secret]

    D --> F{is_non_interactive\n&& requires_interactive_auth?}
    F -->|Yes| G{if_missing policy\nper secret}
    G -->|ignore / warn| H[return Ok with None\nother providers unaffected]
    G -->|error| I[return Err\nfail fast]
    F -->|No| J[try_batch_with_auth_retry]
    J --> K[try_get_secrets_batch]
    K --> L{Batch succeeds?}
    L -->|Yes| M[return results]
    L -->|No auth error| N[prompt_and_run_auth\n⚠️ NOT guarded by is_non_interactive]
    N -->|is_auth_error? No| O[return Err]
    N -->|is_auth_error? Yes\n& is TTY| P[eprintln! + demand::Confirm\n💥 TUI corruption risk]

    E --> Q{is_non_interactive\n&& requires_interactive_auth?}
    Q -->|Yes| R[return Err\nbypasses if_missing]
    Q -->|No| S[get_provider_resolved\nthen get_secret]

_{Last reviewed commit: 5c790c1}