Report StopIteration if connection is closed (#2270)#2277
Merged
duderino merged 2 commits intoistio:release-1.1from Jun 14, 2019
Merged
Report StopIteration if connection is closed (#2270)#2277duderino merged 2 commits intoistio:release-1.1from
duderino merged 2 commits intoistio:release-1.1from
Conversation
* Report StopIteration if connection is closed * Change ENVOY_LOG to ENVOY_CONN_LOG
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazyxy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@crazyxy you need to run make lint |
Member
Author
I don't know why merging to master branch doesn't have format issue. I sent another pr to master branch and will cherry pick that pr to this after merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report StopIteration if connection is closed
Change ENVOY_LOG to ENVOY_CONN_LOG
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: