Skip to content

Format filter.cc#2279

Merged
istio-testing merged 1 commit intoistio:masterfrom
yxue:master
Jun 14, 2019
Merged

Format filter.cc#2279
istio-testing merged 1 commit intoistio:masterfrom
yxue:master

Conversation

@yxue
Copy link
Copy Markdown
Member

@yxue yxue commented Jun 14, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 14, 2019
@yxue yxue changed the title Fix lint in filter.cc Lint in filter.cc Jun 14, 2019
@yxue yxue changed the title Lint in filter.cc Re-format filter.cc Jun 14, 2019
lambdai
lambdai approved these changes Jun 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lambdai lambdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazyxy, silentdai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yxue yxue changed the title Re-format filter.cc Format filter.cc Jun 14, 2019
@istio-testing istio-testing merged commit 5c150dd into istio:master Jun 14, 2019
yxue added a commit to yxue/proxy that referenced this pull request Jun 14, 2019
@yxue
Fix lint (istio#2279)
8e6ce67
yxue added a commit to yxue/proxy that referenced this pull request Jun 14, 2019
@yxue
Fix lint (istio#2279)
779db09
duderino pushed a commit that referenced this pull request Jun 14, 2019
@yxue
Report StopIteration if connection is closed (#2270) (#2277)
ae671c5 
* Report StopIteration if connection is closed (#2270)

* Report StopIteration if connection is closed

* Change ENVOY_LOG to ENVOY_CONN_LOG

* Fix lint (#2279)
duderino pushed a commit that referenced this pull request Jun 14, 2019
@yxue
Report StopIteration if connection is closed (#2270) (#2278)
7767d3a 
* Report StopIteration if connection is closed (#2270)

* Report StopIteration if connection is closed

* Change ENVOY_LOG to ENVOY_CONN_LOG

* Fix lint (#2279)
@yangminzhu yangminzhu mentioned this pull request Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duderino duderino Awaiting requested review from duderino

@rshriram rshriram Awaiting requested review from rshriram

1 more reviewer

@lambdai lambdai lambdai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lambdai lambdai

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yxue @istio-testing @lambdai @googlebot