Skip to content

Report StopIteration if connection is closed#2270

Merged
istio-testing merged 3 commits intoistio:masterfrom
yxue:segfault
Jun 14, 2019
Merged

Report StopIteration if connection is closed#2270
istio-testing merged 3 commits intoistio:masterfrom
yxue:segfault

Conversation

@yxue
Copy link
Copy Markdown
Member

@yxue yxue commented Jun 13, 2019

What this PR does / why we need it: Fix segment fault.

Which issue this PR fixes : fixes istio/istio#14707

Special notes for your reviewer:

Release note:

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazyxy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested review from duderino and lizan June 13, 2019 02:22
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 13, 2019
lizan
lizan reviewed Jun 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a envoy bug, can you file an issue in envoy and add a TODO saying this is a workaround for that?

@yxue
Copy link
Copy Markdown
Member Author

yxue commented Jun 13, 2019 •
edited
Loading

This seems a envoy bug, can you file an issue in envoy and add a TODO saying this is a workaround for that?

@lizan I also made the change for upstream Envoy. Could you also please take a look at this pr? envoyproxy/envoy#7256

duderino
duderino reviewed Jun 13, 2019
View reviewed changes
@yxue
Copy link
Copy Markdown
Member Author

yxue commented Jun 13, 2019

/test proxy-presubmit
/test proxy-presubmit-asan
/test proxy-presubmit-tsan

@bianpengyuan
Copy link
Copy Markdown
Contributor

bianpengyuan commented Jun 13, 2019

@crazyxy just FYI I am investigating prow build failure.

@duderino duderino mentioned this pull request Jun 13, 2019
Merged
@duderino
Copy link
Copy Markdown

duderino commented Jun 14, 2019

/approved

@duderino duderino added the lgtm label Jun 14, 2019
@istio-testing istio-testing merged commit af8f3c8 into istio:master Jun 14, 2019
yxue added a commit to yxue/proxy that referenced this pull request Jun 14, 2019
@yxue
Report StopIteration if connection is closed (istio#2270)
5743702 
* Report StopIteration if connection is closed

* Change ENVOY_LOG to ENVOY_CONN_LOG
yxue added a commit to yxue/proxy that referenced this pull request Jun 14, 2019
@yxue
Report StopIteration if connection is closed (istio#2270)
3af98c1 
* Report StopIteration if connection is closed

* Change ENVOY_LOG to ENVOY_CONN_LOG
duderino pushed a commit that referenced this pull request Jun 14, 2019
@yxue
Report StopIteration if connection is closed (#2270) (#2277)
ae671c5 
* Report StopIteration if connection is closed (#2270)

* Report StopIteration if connection is closed

* Change ENVOY_LOG to ENVOY_CONN_LOG

* Fix lint (#2279)
duderino pushed a commit that referenced this pull request Jun 14, 2019
@yxue
Report StopIteration if connection is closed (#2270) (#2278)
7767d3a 
* Report StopIteration if connection is closed (#2270)

* Report StopIteration if connection is closed

* Change ENVOY_LOG to ENVOY_CONN_LOG

* Fix lint (#2279)
@yangminzhu yangminzhu mentioned this pull request Jul 4, 2019
Merged
@yxue yxue deleted the segfault branch October 11, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lizan lizan lizan left review comments

@duderino duderino duderino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segfault in Envoy

6 participants

@yxue @istio-testing @bianpengyuan @duderino @lizan @googlebot