Skip to content

Add release-note instruction.#980

Merged
istio-merge-robot merged 1 commit intomasterfrom
yutongz-patch-1
Sep 29, 2017
Merged

Add release-note instruction.#980
istio-merge-robot merged 1 commit intomasterfrom
yutongz-patch-1

Conversation

@yutongz
Copy link
Copy Markdown
Contributor

@yutongz yutongz commented Sep 28, 2017 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

none

Add instruction about how to get collect release-note from PR description.

Should merge after istio/test-infra#441

@yutongz yutongz mentioned this pull request Sep 28, 2017
Merged
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 29, 2017

thx !
/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 29, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 29, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 29, 2017 •
edited
Loading

@yutongz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-no_auth.sh cfde6e0 link /test e2e-suite-rbac-no_auth
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 29, 2017

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 8c8b8ff into master Sep 29, 2017
@yutongz
Copy link
Copy Markdown
Contributor Author

yutongz commented Sep 29, 2017

@ldemailly Do you know why this test failed?

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 29, 2017

some connection error:

W0929 00:30:29.029] W0929 00:30:29.027468 891 mixer_test.go:684] Error communicating with http://35.188.246.118/productpage: Get http://35.188.246.118/productpage: dial tcp 35.188.246.118:80: i/o timeout

was there a network outage ?

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 29, 2017

or maybe we ran out of ip/firewalls again - did we ever find out why we seem to leak them?

@yutongz
Copy link
Copy Markdown
Contributor Author

yutongz commented Sep 29, 2017

Right before this error message, it shows all pods are ready and running, it's wired.
Quota is fine. But yes, it seems when delete a cluster, GCP didn't properly handle some of the resources, not only firewall rule, but also forwarding rule and target pools.

@ldemailly ldemailly deleted the yutongz-patch-1 branch October 3, 2017 22:06
rshriram pushed a commit that referenced this pull request Oct 30, 2017
@yutongz @istio-merge-robot
Update README.md (#980)
7ee37cd 
Automatic merge from submit-queue

Add release-note instruction.

**What this PR does / why we need it**:

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
none
```

Add instruction about how to get collect release-note from PR description.

Should merge after istio/test-infra#441

Former-commit-id: 8c8b8ff
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@yutongz @istio-merge-robot
Update README.md (istio#980)
44af091 
Automatic merge from submit-queue

Add release-note instruction.

**What this PR does / why we need it**:

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
none
```

Add instruction about how to get collect release-note from PR description.

Should merge after istio/test-infra#441

Former-commit-id: 8c8b8ff
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@ldemailly @kyessenov
git ls-files|xargs sed -i .bak -e 's/PullPolicy: Always/PullPolicy: I…
9b227e7 
…fNotPresent/g' (#980)

Fixes #441

(Manual adjustments to not touch files where trailing newline is
missing + manual change of go file)
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@yutongz @istio-merge-robot
Update README.md (#980)
240750e 
Automatic merge from submit-queue

Add release-note instruction.

**What this PR does / why we need it**:

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
none
```

Add instruction about how to get collect release-note from PR description.

Should merge after istio/test-infra#441

Former-commit-id: 8c8b8ff
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@theganyo @istio-merge-robot
allow script/check-style to work on MacOS (istio#980)
2c87d97 
Automatic merge from submit-queue.

allow script/check-style to work on MacOS

**What this PR does / why we need it**: allows script/check-style to work on MacOS

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes istio#978

**Special notes for your reviewer**: Tested on MacOS and GLinux

**Release note**:

```release-note
```
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@yangminzhu @mergify
authn: add a field to confrol trust domain validation (istio#980)
36b4225 
* authn: add a field to confrol trust domain validation

* update comments
dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024
@jewertow @openshift-merge-bot
OSSM-6295: Copy all annotations and labels added by ArgoCD except `ar…
e410ee5 
…gocd.argoproj.io/instance` (istio#980)

* Fix IOR wrongly copying argocd internal annotation from Gateway to route (istio#936)
* Fix IOR wrongly copying argocd label from Gateway to route (istio#957)
* OSSM-6295: Copy ArgoCD annotations from Gateway to Route

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

* OSSM-6295: Copy all annotations and labels added by ArgoCD except argocd.argoproj.io/instance

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

* Fix lint errors

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

---------

Co-authored-by: Julien DELACROIX <jdelacroix@ncelrnd2812.nce.amadeus.net>
Co-authored-by: Jacek Ewertowski <jewertow@redhat.com>
Signed-off-by: Yann Liu <yannliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yutongz @ldemailly @istio-merge-robot @istio-testing @googlebot