Skip to content

put back bookinfo-v1.yaml used by blog#978

Merged
istio-merge-robot merged 3 commits intomasterfrom
fix-blog
Sep 29, 2017
Merged

put back bookinfo-v1.yaml used by blog#978
istio-merge-robot merged 3 commits intomasterfrom
fix-blog

Conversation

@frankbu
Copy link
Copy Markdown
Contributor

@frankbu frankbu commented Sep 28, 2017

This yaml file is referenced by a kubernetes blog article. It is otherwise unused and requires no testing.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Sep 28, 2017

can we move this to a different folder though ?
So that it doesn't get packaged with the release.. Perhaps under the root itself.. Like blog/ where we can put all these files and then fix the links in the kubernetes blog
Ideally, I would even say we put these files in istio.github.io under a ping back blog article

@frankbu
Copy link
Copy Markdown
Contributor Author

frankbu commented Sep 28, 2017 •
edited
Loading

I agree moving it somewhere else, would be best. I can change the references, but there are 3 of them used in the article, so we should move all 3 to the same place - although I'm not sure if the other 2 are used for anything else (e.g. tasks, tests) as well. If they are we would need to keep copies in both dirs.

The 3 yaml files needed by the blog are:

bookinfo-v1.yaml
bookinfo-review-v2.yaml
bookinfo-ratings.yaml

@frankbu
Copy link
Copy Markdown
Contributor Author

frankbu commented Sep 29, 2017

@rshriram I moved bookinfo-v1.yaml to /blog and also made a copy of the other two files (bookinfo-ratings.yaml and bookinfo-reviews-v2.yaml) in /blog as well. If the 2 files are not needed for anything else, we can remove them from the bookinfo sample dir, but we can do that cleanup after the 0.2 release.

@frankbu
Copy link
Copy Markdown
Contributor Author

frankbu commented Sep 29, 2017

/assign @andraxylia

@andraxylia
Copy link
Copy Markdown
Contributor

andraxylia commented Sep 29, 2017

/lgtm

@andraxylia
Copy link
Copy Markdown
Contributor

andraxylia commented Sep 29, 2017

/approve

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 29, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 29, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 29, 2017

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 5bb9334 into master Sep 29, 2017
@frankbu frankbu deleted the fix-blog branch September 29, 2017 17:16
rshriram pushed a commit that referenced this pull request Oct 30, 2017
@frankbu @istio-merge-robot
put back bookinfo-v1.yaml used by blog (#978)
dabc1be 
Automatic merge from submit-queue

put back bookinfo-v1.yaml used by blog

This yaml file is referenced by a kubernetes blog article. It is otherwise unused and requires no testing.

Former-commit-id: 5bb9334
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@frankbu @istio-merge-robot
put back bookinfo-v1.yaml used by blog (istio#978)
ff16f06 
Automatic merge from submit-queue

put back bookinfo-v1.yaml used by blog

This yaml file is referenced by a kubernetes blog article. It is otherwise unused and requires no testing.

Former-commit-id: 5bb9334
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@frankbu @istio-merge-robot
put back bookinfo-v1.yaml used by blog (#978)
e319dc9 
Automatic merge from submit-queue

put back bookinfo-v1.yaml used by blog

This yaml file is referenced by a kubernetes blog article. It is otherwise unused and requires no testing.

Former-commit-id: 5bb9334
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@theganyo @istio-merge-robot
allow script/check-style to work on MacOS (istio#980)
2c87d97 
Automatic merge from submit-queue.

allow script/check-style to work on MacOS

**What this PR does / why we need it**: allows script/check-style to work on MacOS

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes istio#978

**Special notes for your reviewer**: Tested on MacOS and GLinux

**Release note**:

```release-note
```
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@frankbu @mergify
Header manipulation example (istio#978)
f807679 
* Header manipulation example

* regen
dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024
@luksa @openshift-merge-bot
OSSM-6289 Only watch required resources in analysis controller (istio…
eb8efce 
…#978)

Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
Signed-off-by: Yann Liu <yannliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andraxylia andraxylia andraxylia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andraxylia andraxylia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frankbu @rshriram @andraxylia @istio-merge-robot @googlebot @istio-testing