Add release-note collector by yutongz · Pull Request #441 · istio/test-infra

yutongz · 2017-08-31T08:59:16Z

Release note:

none

It's a binary to collect release-note from repos.

Example command:

$ bazel-bin/toolbox/release_note_collector/release_note_collector --repos istio --previous_release 0.2.2 --current_release 0.2.4 --pr_link

And the release-note would be put into a local file, default is in current directory, named ".releasenote"

The example output is:

$ cat istio.releasenote
istio: istio -- 0.2.4 release note
Previous release version: 0.2.2
* Provide default Mixer configuration for prometheus metrics and stdio logs.  https://github.com/istio/istio/pull/866
* test setup doc update  https://github.com/istio/istio/pull/831
* New config model (breaking change). Migration instructions are [here](https://github.com/istio/istio/blob/release-0.2/samples/CONFIG-MIGRATION.md)  https://github.com/istio/istio/pull/829

chxchx · 2017-08-31T20:37:33Z

toolbox/release_note_collector/main.go

+	for _, repo := range repoList {
+		log.Printf("Start fetching release note from %s", repo)
+		queries := createQueryString(repo)
+		log.Printf("Query: %s", queries)


queries is a slice and I was not sure what is the behavior of %s in this case. Maybe %v?

sebastienvas · 2017-08-31T20:47:36Z

toolbox/release_note_collector/main.go

+	order     = flag.String("order", "desc", "The sort order if sort parameter is provided. One of asc or desc.")
+	version   = flag.String("version", "", "Release version")
+	output    = flag.String("output", "./", "Path to output file")
+	startDate = flag.String("start_date", "", "Start date")


You might want to use a ref instead of startDate and endDate. Usually we would ask between 0.1.2 and 0.1.3.

ldemailly · 2017-08-31T20:51:11Z

that's awesome ! are we going to contribute it back to k8s to replace the bash script ~~from hell~~ ( https://github.com/kubernetes/release/blob/master/relnotes )

subscribe

sebastienvas · 2017-08-31T20:51:25Z

if possible I would do:
bazel-bin/toolbox/release_note_collector/release_note_collector --repos istio,mixer --version v0.2.1 --last_release 0.2.0

sebastienvas · 2017-08-31T20:52:23Z

This does not publish release notes right ?

yutongz · 2017-08-31T20:55:27Z

It will gather all release-note in PR description and put it into a local file.

yutongz · 2017-08-31T21:04:55Z

Release-note collected from v0.2.0 to now: https://docs.google.com/a/google.com/document/d/1DKDVGihv4ECtxio6RRU1ig8QLzlPZuiGo5PctMbwGYk/edit?usp=sharing

sebastienvas · 2017-08-31T21:45:45Z

I guess I did not write the right command. I only got 3 notes.

ldemailly · 2017-08-31T23:57:55Z

use june 1st as the start date so we get all the 0.2.x notes ?

yutongz · 2017-09-07T22:07:20Z

/retest

yutongz · 2017-09-25T22:12:11Z

toolbox/util/githubClient.go

-	if err != nil {
-		return "", err
+
+	if ty == "tag" {


Change here because some tags point to a tag while some point to a commit

GET https://api.github.com/repos/istio/istio/git/refs/tags/0.2.2 { "ref": "refs/tags/0.2.2", "url": "https://api.github.com/repos/istio/istio/git/refs/tags/0.2.2", "object": { "sha": "9ac006e070b88dba19ad26048c1010675d77e321", "type": "commit", "url": "https://api.github.com/repos/istio/istio/git/commits/9ac006e070b88dba19ad26048c1010675d77e321" } }

GET https://api.github.com/repos/istio/mixer/git/refs/tags/0.2.2 { "ref": "refs/tags/0.2.2", "url": "https://api.github.com/repos/istio/mixer/git/refs/tags/0.2.2", "object": { "sha": "f146a9ff912337c3d17261140d69801bd6c5789b", "type": "tag", "url": "https://api.github.com/repos/istio/mixer/git/tags/f146a9ff912337c3d17261140d69801bd6c5789b" } }

yutongz · 2017-09-25T22:12:59Z

PTAL

sebastienvas · 2017-09-25T22:15:59Z

toolbox/release_note_collector/main.go

+	org       = flag.String("user", "istio", "Github owner or org")
+	repos     = flag.String("repos", "", "Github repos, separate using \",\"")
+	label     = flag.String("label", "release-note", "Release-note label")
+	sort      = flag.String("sort", "create", "The sort field. Can be comments, created, or updated.")


the default does not match the list. Could you please create const for those.

type Sort string const ( CREATED = Sort("created") COMMENTS = Sort("comments") )

sebastienvas · 2017-09-25T22:18:59Z

toolbox/release_note_collector/main.go

+	repos     = flag.String("repos", "", "Github repos, separate using \",\"")
+	label     = flag.String("label", "release-note", "Release-note label")
+	sort      = flag.String("sort", "create", "The sort field. Can be comments, created, or updated.")
+	order     = flag.String("order", "desc", "The sort order if sort parameter is provided. One of asc or desc.")


type Order string const ( DESC = Order("desc") ASC = Order("asc") )

sebastienvas · 2017-09-25T23:04:39Z

toolbox/release_note_collector/main.go

+
+func fetchRelaseNoteFromRepo(repo string, issuesResult *github.IssuesSearchResult) error {
+	fileName := filepath.Join(*output, repo+releaseNoteSuffix)
+	f, err := os.OpenFile(fileName, os.O_WRONLY|os.O_TRUNC|os.O_CREATE, 0600)


Could you move the file creation outside of this function and just pass an io.Writer instead ? That way we could use one file for all repos.

sebastienvas

Nice. Minor changes. Once we have this committed we should update this page https://github.com/istio/istio/tree/master/release

yutongz · 2017-09-25T23:37:40Z

/retest

istio-merge-robot · 2017-10-04T00:14:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly, sebastienvas

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [sebastienvas]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

istio-merge-robot · 2017-10-04T04:49:48Z

/test all [submit-queue is verifying that this PR is safe to merge]

yutongz · 2017-10-04T04:50:10Z

/hold

istio-merge-robot · 2017-10-04T18:10:08Z

/test all [submit-queue is verifying that this PR is safe to merge]

ldemailly · 2017-10-05T01:29:28Z

why hold ?

yutongz · 2017-10-05T17:23:48Z

/hold cancel

istio-merge-robot · 2017-10-05T17:24:31Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2017-10-05T18:22:10Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @ldemailly @sebastienvas @yutongz

yutongz · 2017-10-05T18:23:20Z

@ldemailly For fixing linter

istio-merge-robot · 2017-10-05T18:42:36Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2017-10-05T18:44:42Z

Automatic merge from submit-queue.

Automatic merge from submit-queue Add release-note instruction. **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note none ``` Add instruction about how to get collect release-note from PR description. Should merge after istio/test-infra#441 Former-commit-id: 8c8b8ff

Add release-note collector

5e2182b

googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 31, 2017

istio-merge-robot added the release-note-none label Aug 31, 2017

yutongz requested review from chxchx and sebastienvas August 31, 2017 16:52

chxchx reviewed Aug 31, 2017

View reviewed changes

sebastienvas reviewed Aug 31, 2017

View reviewed changes

yutongz added 5 commits September 22, 2017 16:57

WIP

4b08928

WIP

5d3e032

Set time range by release version

a52f1cc

fix compatibility of istio/other repo

7d89cf5

Proper format

591dd0c

yutongz commented Sep 25, 2017

View reviewed changes

sebastienvas reviewed Sep 25, 2017

View reviewed changes

sebastienvas suggested changes Sep 25, 2017

View reviewed changes

yutongz added 2 commits September 26, 2017 22:22

output into single file

5f0af9c

Merge remote-tracking branch 'upstream/master' into release-note

95224b0

yutongz force-pushed the release-note branch from 3343797 to 95224b0 Compare September 28, 2017 23:36

istio-testing assigned sebastienvas Oct 4, 2017

sebastienvas approved these changes Oct 4, 2017

View reviewed changes

istio-merge-robot added the approved label Oct 4, 2017

yutongz added the cla: human-approved label Oct 4, 2017

istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Oct 4, 2017

yutongz added the do-not-merge Block automatic merging of a PR. label Oct 4, 2017

yutongz removed do-not-merge Block automatic merging of a PR. cla: human-approved labels Oct 5, 2017

istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Oct 5, 2017

Merge remote-tracking branch 'upstream/master' into release-note

7be165d

yutongz added the cla: human-approved label Oct 5, 2017

fix linter

a7ed7f3

istio-merge-robot removed the lgtm label Oct 5, 2017

yutongz added the lgtm label Oct 5, 2017

istio-merge-robot merged commit 0890c14 into istio:master Oct 5, 2017

yutongz deleted the release-note branch October 23, 2017 21:19

Conversation

yutongz commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chxchx Aug 31, 2017

Choose a reason for hiding this comment

Uh oh!

sebastienvas Aug 31, 2017

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Aug 31, 2017

Uh oh!

sebastienvas commented Aug 31, 2017

Uh oh!

sebastienvas commented Aug 31, 2017

Uh oh!

yutongz commented Aug 31, 2017

Uh oh!

yutongz commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebastienvas commented Aug 31, 2017

Uh oh!

ldemailly commented Aug 31, 2017

Uh oh!

yutongz commented Sep 7, 2017

Uh oh!

yutongz Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

yutongz commented Sep 25, 2017

Uh oh!

sebastienvas Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

sebastienvas Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

sebastienvas Sep 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienvas Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

yutongz commented Sep 25, 2017

Uh oh!

istio-merge-robot commented Oct 4, 2017

Uh oh!

istio-merge-robot commented Oct 4, 2017

Uh oh!

yutongz commented Oct 4, 2017

Uh oh!

istio-merge-robot commented Oct 4, 2017

Uh oh!

ldemailly commented Oct 5, 2017

Uh oh!

yutongz commented Oct 5, 2017

Uh oh!

istio-merge-robot commented Oct 5, 2017

Uh oh!

istio-merge-robot commented Oct 5, 2017

Uh oh!

yutongz commented Oct 5, 2017

Uh oh!

istio-merge-robot commented Oct 5, 2017

Uh oh!

istio-merge-robot commented Oct 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yutongz commented Aug 31, 2017 •

edited

Loading

yutongz commented Aug 31, 2017 •

edited

Loading

sebastienvas Sep 25, 2017 •

edited

Loading