Skip to content

Fix misplaced serviceAccoutName in istio-egress#482

Merged
ldemailly merged 3 commits intoistio:masterfrom
suguru:fix-istio-egress-yaml
Jul 20, 2017
Merged

Fix misplaced serviceAccoutName in istio-egress#482
ldemailly merged 3 commits intoistio:masterfrom
suguru:fix-istio-egress-yaml

Conversation

@suguru
Copy link
Copy Markdown
Contributor

@suguru suguru commented Jul 20, 2017

kubectl apply install/kubernetes/istio.yaml causes an error after merging #481

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 20, 2017

Hi @suguru. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@terinjokes
Copy link
Copy Markdown

terinjokes commented Jul 20, 2017

This change should also be made to the template at install/kubernetes/templates/istio-egress.yaml

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Jul 20, 2017

still has

error: yaml: line 13: did not find expected key
/home/jenkins/workspace/istio-armada-release-test/tests/kubeUtils.sh: line 41: Failed to create control plane (exit 1)

on the ibm tests

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 20, 2017

just FYI - the GKE version is 1.6.*, the IBM version is 1.5.6 .. This gives us a range of k8s versions to test.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 20, 2017

/ok-to-test

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Jul 20, 2017

Thanks a lot @suguru for this fix !

@ldemailly ldemailly merged commit 11051df into istio:master Jul 20, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
@ZackButcher
Implement validation using descriptors for the quotas aspect (istio#482)
6a28c38 
* Implement validation using descriptors for the quotas aspect

* Remove comments from tests, add quota descriptor to global config


Former-commit-id: 27e94989a244cf0d27f0fe3d92c5997881196083
rshriram pushed a commit that referenced this pull request Oct 30, 2017
@suguru @ldemailly
Fix misplaced serviceAccoutName in istio-egress (#482)
7713b3d 
* Fix misplaced serviceAccoutName in istio-egress

* Fix serviceAccoutName in istio-egress template


Former-commit-id: 11051df
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@ZackButcher
Implement validation using descriptors for the quotas aspect (#482)
abfeb78 
* Implement validation using descriptors for the quotas aspect

* Remove comments from tests, add quota descriptor to global config


Former-commit-id: ea96b720913a42110d93eb7b11762d3599618793
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@suguru @ldemailly
Fix misplaced serviceAccoutName in istio-egress (istio#482)
ddb4fc4 
* Fix misplaced serviceAccoutName in istio-egress

* Fix serviceAccoutName in istio-egress template


Former-commit-id: 11051df
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@suguru @ldemailly
Fix misplaced serviceAccoutName in istio-egress (#482)
2c0554d 
* Fix misplaced serviceAccoutName in istio-egress

* Fix serviceAccoutName in istio-egress template


Former-commit-id: 11051df
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@jwendell @istio-testing
CNI: Use global hub & tag by default (istio#482)
dbe649e
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@istio-testing
update sha for installer to include automtls change (istio#482)
4cbf620 
* update sha for installer to include automtls change

* make gen with container build

* manual update the default.yaml, ci not failing dueo to configmap

* change default.yaml

* refresh golden

* fix licenses
incfly pushed a commit to incfly/istio that referenced this pull request Nov 16, 2021
@morepork @gy95
fix add mutex lock to protect ClusterVIPs read/write (istio#34326) (i…
3eb2ca0 
…stio#482)

Cherry pick from upstream istio:
istio#34326

Co-authored-by: gy95 <1015105054@qq.com>
antonioberben pushed a commit to antonioberben/istio that referenced this pull request Jan 29, 2024
@mehta-ankit
Merge pull request istio#482 from sam-mcbr/colhpa
fef7bf5 
[jaeger] Configure collector and ingester HPAs to only deploy if component is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@terinjokes terinjokes terinjokes approved these changes

@andraxylia andraxylia andraxylia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@suguru @istio-testing @terinjokes @ldemailly @rshriram @andraxylia @googlebot