fix add mutex lock to protect ClusterVIPs read/write#34326
Merged
istio-testing merged 1 commit intoistio:masterfrom Jul 27, 2021
Merged
fix add mutex lock to protect ClusterVIPs read/write#34326istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
Member
Author
|
/test integ-pilot-multicluster-tests_istio |
hzxuzhonghu
approved these changes
Jul 27, 2021
Member
|
/test release-notes_istio |
Collaborator
|
In response to a cherrypick label: new pull request created: #34350 |
This was referenced Jul 27, 2021
Collaborator
|
In response to a cherrypick label: new pull request created: #34351 |
Collaborator
|
In response to a cherrypick label: new pull request created: #34352 |
morepork
pushed a commit
to tetratelabs/istio
that referenced
this pull request
Aug 18, 2021
Cherry pick from upstream istio: istio#34326
This was referenced Aug 18, 2021
Closed
morepork
added a commit
to tetratelabs/istio
that referenced
this pull request
Aug 19, 2021
) Cherry pick from upstream istio: istio#34326 Co-authored-by: gy95 <1015105054@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is one place where to forget add Mutex protect, add Mutex to protect read/write
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.