Generate JUnit Results for E2E Tests on Prow#3542
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Gopkg.toml
Outdated
There was a problem hiding this comment.
With the subvendor repo I think there's now some rule about dependencies have to be updated independent of code changes but I'm not sure if this means the toml file is separate or only the actual upload of the vendor content.
There was a problem hiding this comment.
Can you include junit report in the base image used by prow - like it is done in circleci ?
There was a problem hiding this comment.
yes matt is correct, you need to rebase, rm your vendor dir if it's not the git submodule backed one
do make pull (or make submodule-sync)
then run dep ensure and cd in vendor/ and make a PR for the changes first
https://github.com/istio/istio/wiki/Vendor-FAQ#how-do-i-add--change-a-dependency
I'm glad someone (beside me) will help test/confirm that process
There was a problem hiding this comment.
oh and costin is correct too, as we don't use junit-report for building istio itself nor its tests, it probably doesn't belong in Gopkg.toml
this being said I wonder how we capture tool chain dependencies/versions ?
There was a problem hiding this comment.
Junit results harness has moved to makefile so circle ci also benefits from this.
Tool chain dependencies are captured with a version-tracked base docker image. Here is my other PR updating this image per request by Costin https://github.com/istio/test-infra/pull/698/files
prow/e2e-suite.sh
Outdated
There was a problem hiding this comment.
I'm unclear about what is accomplished by the ">&1". I'd understand "2>&1" but this seems to pipe stdout to itself. It this a no-op or does it have some other side effect? I thought this might be to allow stdout to be both output and captured but that's not what happened for me and instead I had to resort to something like:
make e2e_all > tee >(go-junit-report > junit.xml)
There was a problem hiding this comment.
That was my intention to log to console and to stream through pipe. you are right, >&1 really does nothing since the log already prints to stdout by default, which is then dup-ed to whichever file descriptor console/tty is at. What I had was essentially redirecting stdout to stdout... Good catch. I have patched with your fix.
1b1f7f9 to
72e6cff
Compare
costinm
left a comment
There was a problem hiding this comment.
Looks good in general, but please address my 2 comments.
prow/e2e-suite.sh
Outdated
There was a problem hiding this comment.
Can you move this to the makefile, so it can be used in circleci too ?
Gopkg.toml
Outdated
There was a problem hiding this comment.
Can you include junit report in the base image used by prow - like it is done in circleci ?
|
/test e2e-simple We renamed e2e-smoke to e2e-bookInfo and added e2e-simple |
|
/hold |
|
@chxchx PR needs rebase |
Automatic merge from submit-queue. Add /opt/go/bin to PATH in Prow Base Image Required to make go-junit-report binary accessible in prow base image. Helps unblock istio/istio#3542
11e8a65 to
8f007f4
Compare
|
try not force pushing once comments started to come |
158c481 to
eb303e2
Compare
|
@chxchx: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue. Add /opt/go/bin to PATH in Prow Base Image Required to make go-junit-report binary accessible in prow base image. Helps unblock istio/istio#3542
Also removed the uploadDir() deadcode since we now use bootstrap to update all logs and artifacts automatically when process exits