Skip to content

Add /opt/go/bin to PATH in Prow Base Image#702

Merged
istio-merge-robot merged 2 commits intoistio:masterfrom
chxchx:img042
Feb 20, 2018
Merged

Add /opt/go/bin to PATH in Prow Base Image#702
istio-merge-robot merged 2 commits intoistio:masterfrom
chxchx:img042

Conversation

@chxchx
Copy link
Copy Markdown
Contributor

@chxchx chxchx commented Feb 20, 2018

Required to make go-junit-report binary accessible in prow base image. Helps unblock istio/istio#3542

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 20, 2018
@chxchx chxchx requested review from nlandolfi and removed request for nlandolfi February 20, 2018 23:02
@chxchx chxchx changed the title Add /opt/go/bin to PATH Add /opt/go/bin to PATH in Prow Base Image Feb 20, 2018
@chxchx
Copy link
Copy Markdown
Contributor Author

chxchx commented Feb 20, 2018

/assign @sebastienvas @rkpagadala

@rkpagadala
Copy link
Copy Markdown
Contributor

rkpagadala commented Feb 20, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkpagadala

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 20, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 118535e into istio:master Feb 20, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 20, 2018

@chxchx: I updated Prow config for you!

Details

In response to this:

Required to make go-junit-report binary accessible in prow base image. Helps unblock istio/istio#3542

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rkpagadala rkpagadala

@sebastienvas sebastienvas

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chxchx @rkpagadala @istio-merge-robot @istio-testing @googlebot @sebastienvas