Conversation
prow/e2e-simpleTests.sh
Outdated
| @@ -0,0 +1,32 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Copyright 2017 Istio Authors | |||
There was a problem hiding this comment.
Offhand it looks like prow/config.yaml in the test-infra repo might need to be updated to reflect the rename of e2e-smoke.sh.
|
/lgtm |
yutongz
left a comment
There was a problem hiding this comment.
/lgtm
/hold
Wait until Andy comes back from meetings.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rkpagadala, yutongz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
nit: make prow/e2e-simpleTests.sh executable |
|
@hklai: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-simpleTests |
|
/test e2e-bookInfoTests |
|
/test e2e-simpleTests |
|
/test e2e-simple |
|
/test e2e-bookInfo |
|
ty! |
|
but it failed? |
|
both bookInfo and simple tests passed in this PR. Where do you see the failures? |
|
it was the link/failure above - but somehow the error changed or I misremembered https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/3529/e2e-smoke/3031/ |
|
That happened in the time window between the two PRs I merged.
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/3557/e2e-simpleTests/36/
is probably a more real error, but it also means the simple test is flaky.
…On Fri, Feb 16, 2018 at 12:44 AM, Laurent Demailly ***@***.*** > wrote:
it was the link/failure above - but somehow the error changed or I
misremembered
https://k8s-gubernator.appspot.com/build/istio-prow/
pull/istio_istio/3529/e2e-smoke/3031/
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3529 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AeRtkP5-daxNT60FfS_3gn6qV4xv5W0aks5tVT_RgaJpZM4SHZE8>
.
|
Fixes #3509