Skip to content

Update prow config to include simpleTests#694

Merged
istio-merge-robot merged 1 commit intomasterfrom
hklai_presubmit_tests
Feb 16, 2018
Merged

Update prow config to include simpleTests#694
istio-merge-robot merged 1 commit intomasterfrom
hklai_presubmit_tests

Conversation

@hklai
Copy link
Copy Markdown
Contributor

@hklai hklai commented Feb 15, 2018

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 15, 2018
@hklai
Copy link
Copy Markdown
Contributor Author

hklai commented Feb 15, 2018

istio/istio#3529

@hklai hklai mentioned this pull request Feb 15, 2018
Merged
@rkpagadala
Copy link
Copy Markdown
Contributor

rkpagadala commented Feb 15, 2018

/lgtm
/hold until istio/istio#3529 is merged

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkpagadala

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 15, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@rkpagadala
Copy link
Copy Markdown
Contributor

rkpagadala commented Feb 15, 2018

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Feb 15, 2018
@yutongz
Copy link
Copy Markdown
Contributor

yutongz commented Feb 15, 2018

We need to merge this first, but yes, let's hold it until Andy comes back from meetings.
@hklai When you are ready, just commet "/hold cancel"

@hklai
Copy link
Copy Markdown
Contributor Author

hklai commented Feb 16, 2018

/hold cancel

Ready to roll

@istio-testing istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Feb 16, 2018
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 16, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 16, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 5b43047 into master Feb 16, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 16, 2018

@hklai: I updated Prow config for you!

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yutongz yutongz deleted the hklai_presubmit_tests branch March 9, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rkpagadala rkpagadala

@yutongz yutongz

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hklai @rkpagadala @istio-merge-robot @yutongz @istio-testing @googlebot