Re-enable pprof for mixer with args consistent with Pilot#3539
Re-enable pprof for mixer with args consistent with Pilot#3539istio-merge-robot merged 2 commits intoistio:masterfrom
Conversation
|
/test istio-pilot-e2e |
mixer/pkg/server/monitoring.go
Outdated
There was a problem hiding this comment.
Can you create a unit test for this? The server package has 100% coverage, it'd be nice to stay there :-)
There was a problem hiding this comment.
the default being true, it's covered
|
/test e2e-simple We renamed e2e-smoke to e2e-bookInfo and added e2e-simple |
|
@mandarjog do we want some sort of integration test to validate this works as expected to go along with the unit test? |
|
/test istio-pilot-e2e |
e1646bf to
b0c4876
Compare
|
/lgtm |
|
linter are fixed (#3591 ) so you should be good to go /test istio-pilot-e2e |
Signed-off-by: Mandar U Jog <mjog@google.com>
Signed-off-by: Mandar U Jog <mjog@google.com>
b0c4876 to
2a6ebcf
Compare
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @ldemailly @mandarjog |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@mandarjog: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Enable pprof at http://localhost:9093/debug/pprof/* with command line args consistent with Pilot.
Signed-off-by: Mandar U Jog mjog@google.com