Skip to content

Lint fixups in master#3591

Merged
ldemailly merged 1 commit intoistio:masterfrom
awwithro:lint_fixup
Feb 17, 2018
Merged

Lint fixups in master#3591
ldemailly merged 1 commit intoistio:masterfrom
awwithro:lint_fixup

Conversation

@awwithro
Copy link
Copy Markdown
Contributor

@awwithro awwithro commented Feb 17, 2018 •
edited
Loading

Introduced in #3368

mixer/adapter/dogstatsd/dogstatsd.go:150:2:error: should write info := h.metrics[mname] instead of info, _ := h.metrics[mname] (S1005) (megacheck)
mixer/adapter/dogstatsd/dogstatsd.go:51:2:error: this value of client is never used (SA4006) (megacheck)
mixer/adapter/dogstatsd/dogstatsd.go:101:14:error: error return value not checked (ce.Appendf("metricName", "%s is a valid metric but is not configured to be handled by the datadog adapter", mname)) (errcheck)
mixer/adapter/dogstatsd/dogstatsd_test.go:225:12:error: this value of err is never used (SA4006) (megacheck)

@awwithro awwithro requested a review from a team February 17, 2018 23:46
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 17, 2018

Hi @awwithro. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awwithro awwithro mentioned this pull request Feb 17, 2018
Merged
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 17, 2018

/lgtm
thx!

ldemailly
ldemailly approved these changes Feb 17, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming linters are now happy

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Feb 17, 2018
Closed
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 17, 2018

merging this as linter (which was broken) + tests passed - master is broken without this pr

@ldemailly ldemailly merged commit b283d49 into istio:master Feb 17, 2018
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 17, 2018

thanks for the quick fix @awwithro - the reason it broke is related to #3471

@ldemailly ldemailly mentioned this pull request Feb 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

kind/test failure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@awwithro @istio-testing @ldemailly @istio-merge-robot @googlebot