Skip to content

Checking linters (do not merge, test pr)#3587

Closed
ldemailly wants to merge 1 commit intomasterfrom
linter_test
Closed

Checking linters (do not merge, test pr)#3587
ldemailly wants to merge 1 commit intomasterfrom
linter_test

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Feb 17, 2018

@ldemailly ldemailly requested a review from a team February 17, 2018 17:45
@ldemailly ldemailly changed the title Checking linters Checking linters (do not merge, test pr) Feb 17, 2018
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Feb 17, 2018

cc @mandarjog

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 17, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: mandarjog

Assign the PR to them by writing /assign @mandarjog in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Feb 17, 2018
Merged
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 17, 2018

@ldemailly: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 1ca2cfb link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Feb 17, 2018

fix coming in #3591

@ldemailly ldemailly closed this Feb 17, 2018
@ldemailly ldemailly deleted the linter_test branch March 8, 2018 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ldemailly @istio-merge-robot @istio-testing @googlebot