Add Mixer integration tests#207
Merged
douglas-reid merged 9 commits intoistio:masterfrom May 10, 2017
douglas-reid:mixerTests
Merged
Add Mixer integration tests#207douglas-reid merged 9 commits intoistio:masterfrom douglas-reid:mixerTests
douglas-reid merged 9 commits intoistio:masterfrom
douglas-reid:mixerTests
Conversation
ayj
reviewed
May 8, 2017
tests/e2e/framework/istioctl.go
Outdated
Contributor
There was a problem hiding this comment.
--istioNamespace %s is needed to specify namespace of istio system components (see CreateRule above for example).
ayj
reviewed
May 8, 2017
tests/e2e/tests/mixer/mixer_test.go
Outdated
Contributor
There was a problem hiding this comment.
Liens 123-130 shouldn't be needed anymore with #205.
Contributor
Author
There was a problem hiding this comment.
These should now be removed.
Contributor
Author
|
Thanks for the review! I've updated to match comments (and upgrade istioctl). PTAL. |
mandarjog
reviewed
May 9, 2017
tests/e2e/tests/mixer/mixer_test.go
Outdated
Contributor
There was a problem hiding this comment.
perhaps use ori or rename ori-- > []byte content
Contributor
Author
There was a problem hiding this comment.
section removed.
tests/e2e/tests/mixer/mixer_test.go
Outdated
Contributor
There was a problem hiding this comment.
not this PR directly, but if we are going to use kubectl, so often we need a util.kubectl
@sebastienvas, or use real kubeapi
sebastienvas
reviewed
May 9, 2017
tests/e2e/tests/mixer/mixer_test.go
Outdated
Contributor
There was a problem hiding this comment.
If you are not modifying the rules, you can just use the original file.
Contributor
Author
There was a problem hiding this comment.
true. this code copies to t.rulesDir, which makes it easier to reference tc.rulesDir later in the create rules blocks. i'll update the code to make that clearer.
Contributor
Author
There was a problem hiding this comment.
updated to just use os.Link() instead of copying the files around.
sebastienvas
reviewed
May 9, 2017
istio.VERSION
Outdated
Contributor
There was a problem hiding this comment.
This is not a commit in master
Contributor
Author
There was a problem hiding this comment.
OK. We need a new ISTIOCTL_URL with the latest fix. I just found one that worked. Do you know what the latest in master is?
Contributor
There was a problem hiding this comment.
621b2c4c8073dd4e570c2c77f3d6f92f7ba969b2 is the latest commit in istio.io/manager master.
Contributor
There was a problem hiding this comment.
I d rather use a stable tag here. Does stable-c1b35b6 work ?
Contributor
Author
There was a problem hiding this comment.
updated to SHA suggested.
Contributor
Author
|
PTAL. Attempted to address previous comments. Changes include:
Tested on minikube: passed. |
sebastienvas
approved these changes
May 9, 2017
Contributor
|
You need to fix the linters issue first tough |
Contributor
|
You can use stable-621b2c4 tag now instead of the SHA. |
Contributor
Author
|
PTAL. Updated:
|
This PR establishes a baseline set of integration tests that exercise some core Mixer features, including: - basic monitoring - denials aspect - rate limiting - adding new telemetry via API There is a lot of room for improvement, but this should establish a decent baseline for verification of behavior. Other apsects, such as whitelisting, will need to be added when support for adding descriptors via API, etc., is supported. Tested with `--use_local_cluster` flag on MPB with minikube.
This PR establishes a baseline set of integration tests that exercise some core Mixer features, including: - basic monitoring - denials aspect - rate limiting - adding new telemetry via API There is a lot of room for improvement, but this should establish a decent baseline for verification of behavior. Other apsects, such as whitelisting, will need to be added when support for adding descriptors via API, etc., is supported. Tested with `--use_local_cluster` flag on MPB with minikube.
Collaborator
|
Jenkins job istio/presubmit passed |
zenlint
pushed a commit
to zenlint/istio
that referenced
this pull request
Aug 30, 2017
…ation (istio#207) * Rename demos to samples * Use paths relative to the root * Use paths relative to the root * Use relative paths * Put back istioctl instr
mandarjog
added a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
* Only run linters on the changed code, except for main build * use vendored linters * break coverage and race as 2 test, runs faster Former-commit-id: ce9efb2dfee2212085d7c1a3f23d99ecb992bb56
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
This PR establishes a baseline set of integration tests that exercise some core Mixer features, including: - basic monitoring - denials aspect - rate limiting - adding new telemetry via API There is a lot of room for improvement, but this should establish a decent baseline for verification of behavior. Other apsects, such as whitelisting, will need to be added when support for adding descriptors via API, etc., is supported. Former-commit-id: 60ae078
mandarjog
added a commit
that referenced
this pull request
Oct 31, 2017
* Only run linters on the changed code, except for main build * use vendored linters * break coverage and race as 2 test, runs faster Former-commit-id: 34169c89106ff26ee56dc4a519467cecf4d5905b
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Add gcp node agent * address comments * address comments * remove unused var
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
This PR establishes a baseline set of integration tests that exercise some core Mixer features, including: - basic monitoring - denials aspect - rate limiting - adding new telemetry via API There is a lot of room for improvement, but this should establish a decent baseline for verification of behavior. Other apsects, such as whitelisting, will need to be added when support for adding descriptors via API, etc., is supported. Former-commit-id: 60ae078
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* Add gcp node agent * address comments * address comments * remove unused var
guptasu
pushed a commit
to guptasu/istio
that referenced
this pull request
Jun 11, 2018
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
rajusharma
pushed a commit
to rajusharma/istio
that referenced
this pull request
Jul 2, 2019
* initial commit * templatize istio-telemetry * add standard labels * update telemetry config namespace * add stackdriver adapter config * rename per comments
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
Enable MacOS based container builds. Depends-On: istio/common-files#30 Depends-On: istio/tools#274
brian-avery
added a commit
to brian-avery/istio
that referenced
this pull request
Feb 12, 2021
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
markusthoemmes
pushed a commit
to markusthoemmes/istio
that referenced
this pull request
Apr 27, 2021
It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157)
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Jun 30, 2021
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Feb 22, 2022
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Apr 29, 2022
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Sep 15, 2022
…ers (istio#236) (istio#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Apr 11, 2024
…ers (istio#236) (istio#544) (istio#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
dgn
pushed a commit
to dgn/istio
that referenced
this pull request
Jun 13, 2024
…io#236) (istio#544) (istio#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes a baseline set of integration tests that exercise
some core Mixer features, including:
There is a lot of room for improvement, but this should establish a
decent baseline for verification of behavior. Other apsects, such
as whitelisting, will need to be added when support for adding
descriptors via API, etc., is supported.
Tested with
--use_local_clusterflag on MPB with minikube.