Use "RoleBinding" instead of ClusterRoleBindings, so it works with namespaces#236
Merged
rshriram merged 5 commits intoistio:masterfrom May 10, 2017
costinm:rbac
Merged
Use "RoleBinding" instead of ClusterRoleBindings, so it works with namespaces#236rshriram merged 5 commits intoistio:masterfrom costinm:rbac
rshriram merged 5 commits intoistio:masterfrom
costinm:rbac
Conversation
andraxylia
approved these changes
May 10, 2017
Collaborator
|
Jenkins job istio/presubmit passed |
zenlint
pushed a commit
to zenlint/istio
that referenced
this pull request
Aug 30, 2017
* Fixing most of remaining bad links Still left : #google.rpc.Code in reference/api/mixer/status And the mixer-config-quota-bookinfo.yaml is missing in https://github.com/istio/istio/tree/master/samples/apps/bookinfo * Add html checking and ignore localhost urls fixed typo in layouts/base found by html checking * Fix duplicate id defined Those anchors don’t seem used btw * Adding back html proofer got removed accidentally it seems * Fix the last 2 errors
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
Automatic merge from submit-queue Use cobra to parse CLI Use Cobra to parse CLI. This fixes issue #226. ```release-note Use cobra to parse CLI ```
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
Automatic merge from submit-queue Use cobra to parse CLI Use Cobra to parse CLI. This fixes issue #226. ```release-note Use cobra to parse CLI ```
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Updates to mesh command help text Updates to mesh command descriptions Added duration units * Fixed line length lint failure * Fixed typos and expanded manifest diff description * Fixed merge error that broke the build
brian-avery
added a commit
to brian-avery/istio
that referenced
this pull request
Feb 12, 2021
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Jun 30, 2021
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Feb 22, 2022
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Apr 29, 2022
…io#236) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com>
vikaschoudhary16
pushed a commit
to vikaschoudhary16/istio
that referenced
this pull request
May 3, 2022
stevenctl
pushed a commit
to stevenctl/istio
that referenced
this pull request
Aug 13, 2022
* Minor clean up to readme also add some steps for sidecar as well * add sidecar to ambient and ambient to sidecar
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Sep 15, 2022
…ers (istio#236) (istio#544) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Apr 11, 2024
…ers (istio#236) (istio#544) (istio#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
dgn
pushed a commit
to dgn/istio
that referenced
this pull request
Jun 13, 2024
…io#236) (istio#544) (istio#712) Rework of this for 1.6 rebase. Adapted from: b0f47f2 MAISTRA-2010 Fix validation of AuthorizationPolicy fields (istio#207) It would previously detect request.regex.headers as invalid, even though it is supported. Cherry-pick of MAISTRA-1739 (istio#157) Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: Brad Ison <brad.ison@redhat.com>
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Feb 10, 2025
…ter-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @yangguan suggestion.