Permit /go/src to be writeable by mere users#274
Merged
istio-testing merged 1 commit intoistio:masterfrom Aug 16, 2019
sdake:buildtools/enable_istioio
Merged
Permit /go/src to be writeable by mere users#274istio-testing merged 1 commit intoistio:masterfrom sdake:buildtools/enable_istioio
istio-testing merged 1 commit intoistio:masterfrom
sdake:buildtools/enable_istioio
Conversation
For the operator repository, it is necessary to enable a CONTAINER_OPTION of:
```
--mount type=volume,source=istio-installer-cache,destination="${GOPATH}/src/istio.io" \
```
This permits putting stuff in ${GOPATH}/src/istio.io. I'm not
convinced the operator repository is doing things correctly
here. This repo checks out a copy of istio.io/installer to
$GOPATH/src/istio.io/installer. This seems problematic as
it may overwrite the existing installer repository. In a
container based build, this simply creates a new docker volume
cache to store this information.
This pattern might be generalizable to other repositories,
in which case we can remove it as a COTAINER_OPTION. Time will tell
if other repositories (ab)use the ${GOPATH}/src directory.
sdake
pushed a commit
to sdake/common-files
that referenced
this pull request
Aug 16, 2019
We need to use the latest container image in the operator repository to enable container based builds (finally). Depends-On: istio/tools#274
sdake
pushed a commit
to sdake/operator
that referenced
this pull request
Aug 16, 2019
Enable MacOS based container builds. Depends-On: istio/common-files#30 Depends-On: istio/tools#274
geeknoid
approved these changes
Aug 16, 2019
istio-testing
pushed a commit
to istio/common-files
that referenced
this pull request
Aug 16, 2019
We need to use the latest container image in the operator repository to enable container based builds (finally). Depends-On: istio/tools#274
istio-testing
pushed a commit
to istio/operator
that referenced
this pull request
Aug 16, 2019
Enable MacOS based container builds. Depends-On: istio/common-files#30 Depends-On: istio/tools#274
ostromart
pushed a commit
to ostromart/operator
that referenced
this pull request
Aug 20, 2019
Enable MacOS based container builds. Depends-On: istio/common-files#30 Depends-On: istio/tools#274
istio-testing
pushed a commit
to istio/operator
that referenced
this pull request
Aug 21, 2019
* Eliminate vfsgen again. (#200) * Fix build commmand for installing go-bindata (#202) * Update makefile for proto related rules (#169) * Update makefile for proto related rules to work for new system * Address comments * Add doc gen * Upload updated pb.go files * Update common * Address comment * Merge two install sections into one (#203) * Merge two install sections into one * Change section title * Update to 2019-08-16 commonfiles (#207) Enable MacOS based container builds. Depends-On: istio/common-files#30 Depends-On: istio/tools#274 * support resource type for k8s mapping. (#206) * support resource type for k8s mapping. * apply comments. * Fix reverse translation issue (#205) * Fix reverse translation issue * Address hpa spec issues * Refactor * Second version of refactor * Address comment * lint * Changes to API for mesh config integration (#210) * Changes to API for mesh config integration * Review comments, add strategy * Add strategy to k8s settings * Fix unit tests * update doc. (#212) * update doc. * apply comments. * update link with recent source. * Clean up values (#214) * remove invalid and duplicated fields. (#217)
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jun 30, 2022
For the operator repository, it is necessary to enable a CONTAINER_OPTION of:
```
--mount type=volume,source=istio-installer-cache,destination="${GOPATH}/src/istio.io" \
```
This permits putting stuff in ${GOPATH}/src/istio.io. I'm not
convinced the operator repository is doing things correctly
here. This repo checks out a copy of istio.io/installer to
$GOPATH/src/istio.io/installer. This seems problematic as
it may overwrite the existing installer repository. In a
container based build, this simply creates a new docker volume
cache to store this information.
This pattern might be generalizable to other repositories,
in which case we can remove it as a COTAINER_OPTION. Time will tell
if other repositories (ab)use the ${GOPATH}/src directory.
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jul 6, 2022
For the operator repository, it is necessary to enable a CONTAINER_OPTION of:
```
--mount type=volume,source=istio-installer-cache,destination="${GOPATH}/src/istio.io" \
```
This permits putting stuff in ${GOPATH}/src/istio.io. I'm not
convinced the operator repository is doing things correctly
here. This repo checks out a copy of istio.io/installer to
$GOPATH/src/istio.io/installer. This seems problematic as
it may overwrite the existing installer repository. In a
container based build, this simply creates a new docker volume
cache to store this information.
This pattern might be generalizable to other repositories,
in which case we can remove it as a COTAINER_OPTION. Time will tell
if other repositories (ab)use the ${GOPATH}/src directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the operator repository, it is necessary to enable a CONTAINER_OPTION of:
This permits putting stuff in ${GOPATH}/src/istio.io. I'm not
convinced the operator repository is doing things correctly
here. This repo checks out a copy of istio.io/installer to
$GOPATH/src/istio.io/installer. This seems problematic as
it may overwrite the existing installer repository. In a
container based build, this simply creates a new docker volume
cache to store this information.
This pattern might be generalizable to other repositories,
in which case we can remove it as a COTAINER_OPTION. Time will tell
if other repositories (ab)use the ${GOPATH}/src directory.