This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Fix build commmand for installing go-bindata#202
Merged
istio-testing merged 1 commit intoistio:masterfrom Aug 15, 2019
Merged
Conversation
sdake
approved these changes
Aug 15, 2019
Member
sdake
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Cheers
-teve
Contributor
|
/cherrypick release-1.3 |
|
@ostromart: #202 failed to apply on top of branch "release-1.3": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ostromart
pushed a commit
to ostromart/operator
that referenced
this pull request
Aug 20, 2019
Merged
istio-testing
pushed a commit
that referenced
this pull request
Aug 21, 2019
* Eliminate vfsgen again. (#200) * Fix build commmand for installing go-bindata (#202) * Update makefile for proto related rules (#169) * Update makefile for proto related rules to work for new system * Address comments * Add doc gen * Upload updated pb.go files * Update common * Address comment * Merge two install sections into one (#203) * Merge two install sections into one * Change section title * Update to 2019-08-16 commonfiles (#207) Enable MacOS based container builds. Depends-On: istio/common-files#30 Depends-On: istio/tools#274 * support resource type for k8s mapping. (#206) * support resource type for k8s mapping. * apply comments. * Fix reverse translation issue (#205) * Fix reverse translation issue * Address hpa spec issues * Refactor * Second version of refactor * Address comment * lint * Changes to API for mesh config integration (#210) * Changes to API for mesh config integration * Review comments, add strategy * Add strategy to k8s settings * Fix unit tests * update doc. (#212) * update doc. * apply comments. * update link with recent source. * Clean up values (#214) * remove invalid and duplicated fields. (#217)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my Mac, I ran into a error building outside the container. The command in the README worked if I prefixed
GO111MODULE=on.