Merged
Conversation
rules_protobuf needs the update for 0.8 support.
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyessenov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
=========================================
- Coverage 81.67% 81.18% -0.5%
=========================================
Files 201 190 -11
Lines 20447 18933 -1514
=========================================
- Hits 16701 15371 -1330
+ Misses 3275 3125 -150
+ Partials 471 437 -34
Continue to review full report at Codecov.
|
Contributor
Author
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
* Reduce log level for jwt filter (istio#1866) * Update_Dependencies (istio#1873) * Correctly clean up headers used for payload from JWT authentication (istio#1879) * Correctly clean up headers used for payload from JWT authentication * Clang * Update_Dependencies (istio#1883) * destination.principal derivation fix (istio#1884) * fix attribute extraction Signed-off-by: Kuat Yessenov <kuat@google.com> * seed mock Signed-off-by: Kuat Yessenov <kuat@google.com> * merge 1.0 to master * Update API SHA (istio#1891) * add needed dependencies for circle ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_protobuf needs the update for 0.8 support.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1868Special notes for your reviewer:
Release note: