Skip to content

Enable LRU cache for check call#1884

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
manlinl:lru_2
Nov 29, 2017
Merged

Enable LRU cache for check call#1884
istio-merge-robot merged 1 commit intoistio:masterfrom
manlinl:lru_2

Conversation

@manlinl
Copy link
Copy Markdown
Contributor

@manlinl manlinl commented Nov 28, 2017

No description provided.

@manlinl manlinl requested a review from apicl November 28, 2017 04:41
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 28, 2017

@manlinl: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2017 •
edited
Loading

Codecov Report

Merging #1884 into master will increase coverage by 0.06%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1884      +/-   ##
=========================================
+ Coverage   81.14%   81.2%   +0.06%     
=========================================
  Files         187     191       +4     
  Lines       18883   19472     +589     
=========================================
+ Hits        15323   15813     +490     
- Misses       3127    3194      +67     
- Partials      433     465      +32
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.45% <87.87%> (+0.07%) ⬆️
#pilot 80.5% <ø> (+0.1%) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/svcctrl/handler.go 35.13% <ø> (ø) ⬆️
mixer/adapter/svcctrl/svcctrl.go 63.3% <100%> (+2.13%) ⬆️
mixer/adapter/svcctrl/checkprocessor.go 76.66% <85.18%> (+6.8%) ⬆️
pilot/platform/kube/inject/http.go 75.86% <0%> (ø)
pilot/platform/kube/inject/inject.go 88.05% <0%> (ø)
pilot/platform/kube/inject/configmap.go 100% <0%> (ø)
pilot/platform/kube/inject/initializer.go 65.41% <0%> (ø)
mixer/adapter/prometheus/server.go 94.91% <0%> (+5.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ec6a3...5f06855. Read the comment docs.

@apicl
Copy link
Copy Markdown
Contributor

apicl commented Nov 29, 2017

/lgtm

@apicl
Copy link
Copy Markdown
Contributor

apicl commented Nov 29, 2017

/approve

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apicl

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@manlinl manlinl added do-not-merge Block automatic merging of a PR. and removed do-not-merge Block automatic merging of a PR. labels Nov 29, 2017
@manlinl
Copy link
Copy Markdown
Contributor Author

manlinl commented Nov 29, 2017

/retest all

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 4a615e5 into istio:master Nov 29, 2017
@manlinl manlinl deleted the lru_2 branch December 14, 2017 23:36
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@rkpagadala
merge 1.0 branch to master (istio#1885)
61f5a41 
* Reduce log level for jwt filter (istio#1866)

* Update_Dependencies (istio#1873)

* Correctly clean up headers used for payload from JWT authentication (istio#1879)

* Correctly clean up headers used for payload from JWT authentication

* Clang

* Update_Dependencies (istio#1883)

* destination.principal derivation fix (istio#1884)

* fix attribute extraction

Signed-off-by: Kuat Yessenov <kuat@google.com>

* seed mock

Signed-off-by: Kuat Yessenov <kuat@google.com>

* merge 1.0 to master

* Update API SHA (istio#1891)

* add needed dependencies for circle ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apicl apicl Awaiting requested review from apicl

Assignees

@apicl apicl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@manlinl @istio-testing @apicl @istio-merge-robot @googlebot @yutongz