Remove code duplication of string to model.Protocol conversion#1866
Merged
rshriram merged 8 commits intoistio:masterfrom Nov 27, 2017
Merged
Remove code duplication of string to model.Protocol conversion#1866rshriram merged 8 commits intoistio:masterfrom
rshriram merged 8 commits intoistio:masterfrom
Conversation
in conversion of a string to model.Protocol, since there are not-all-uppercase protocols like Mongo and Redis
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
- Coverage 81.9% 81.84% -0.07%
==========================================
Files 188 189 +1
Lines 18715 18702 -13
==========================================
- Hits 15328 15306 -22
- Misses 2960 2968 +8
- Partials 427 428 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
- Coverage 81.9% 81.25% -0.65%
==========================================
Files 188 176 -12
Lines 18715 16553 -2162
==========================================
- Hits 15328 13450 -1878
+ Misses 2960 2745 -215
+ Partials 427 358 -69
Continue to review full report at Codecov.
|
GregHanson
approved these changes
Nov 27, 2017
Contributor
Author
|
@ijsnellf could you please add "lgtm" label? In the Labels section. |
rshriram
approved these changes
Nov 27, 2017
vadimeisenbergibm
added a commit
to vadimeisenbergibm/istio
that referenced
this pull request
Nov 28, 2017
…#1866) * added ConvertCaseInsensitiveStringToProtocol and ProtocolUnsupported * remove code duplication in convertProtocol functions * use ConvertCaseInsensitiveStringToProtocol instead of strings.ToUpper in conversion of a string to model.Protocol, since there are not-all-uppercase protocols like Mongo and Redis * removed unused metadata values * added TestConvertCaseInsensitiveStringToProtocol * replaced shadowing variable * Revert "replaced shadowing variable" This reverts commit 6a9981f. * replaced shadowing variable
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
* Reduce log level for jwt filter (istio#1866) * Update_Dependencies (istio#1873) * Correctly clean up headers used for payload from JWT authentication (istio#1879) * Correctly clean up headers used for payload from JWT authentication * Clang * Update_Dependencies (istio#1883) * destination.principal derivation fix (istio#1884) * fix attribute extraction Signed-off-by: Kuat Yessenov <kuat@google.com> * seed mock Signed-off-by: Kuat Yessenov <kuat@google.com> * merge 1.0 to master * Update API SHA (istio#1891) * add needed dependencies for circle ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes code duplication of string to model.Protocol conversion
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
This PR is needed for Mongo and Redis protocols support in Egress Rules
Release note: