You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Sometimes comments I leave are really really important to me because they are bugs that must be fixed before the code is merged! Therefore, tracking review comments is INCREDIBLY IMPORTANT. This will make it easier (more like Phabricator/Phacility (which looks like this, FYI)).
In the "Files changed" review tab, add a little indicator in the top-right of the screen to show which of which comment (ex: number 13 / 64) you are looking at. Have it auto-update the one you are looking at based on your scroll location on the page. Also have a "next comment" and "previous comment" button. Make the current comment number a settable field so someone can type in a comment number to jump straight to it.
Design:
Here's an example of what that might look like in the top-right of the review screen on the "Files changed" tab:
Comment [13 / 64] Next> <Prev
In this layout, the 13 would be the current comment number I am looking at, out of a total of 64 review comments. I can click Next> to jump to the next comment, or <Prev to jump to the previous comment. I can also click on the 13 and edit it to any number, then press Enter to jump to that comment. The 64 is not editable directly.
This would make the review process soooo much easier.
It is CRITICAL that #1786 is also implemented so that we NEVER EVER EVER lose review comments! Any obsolete review comments which can no longer be attached to a file or line or commit should be attached to the PR directly still and just placed at the very top of the "Files changed" tab in chronological order, for all parties to still look at and resolve, edit, or comment on them! SOME COMMENTS ARE CRITICALLY IMPORTANT and this is the only way to give a reviewer power to ensure their really really important review comments are properly implemented before they approve.
Here is a summary of the message I just sent to Github. If you'd like to see these issues implemented too, contact GitHub yourselves and let them know! Feel free to copy and paste the message I've used below, or write your own, linking back to these issues you care about.
Dear GitHub,
Tracking really important review comments, and not losing them, is CRITICAL in order to ensure, as a reviewer, that all necessary review comments are implemented before I click approve. Here are 5 related issues I request you implement to dramatically improve this process. I wrote the first 3 of these 5 and feel very strongly about them. Please consider making this a priority as your enterprise customers (I am one of them) could really benefit from it as well. Thanks!
Here are the 5 issues I'd like to see implemented, in order of most important to me first:
Sometimes comments I leave are really really important to me because they are bugs that must be fixed before the code is merged! Therefore, tracking review comments is INCREDIBLY IMPORTANT. This will make it easier (more like Phabricator/Phacility (which looks like this, FYI)).
In the "Files changed" review tab, add a little indicator in the top-right of the screen to show which of which comment (ex: number 13 / 64) you are looking at. Have it auto-update the one you are looking at based on your scroll location on the page. Also have a "next comment" and "previous comment" button. Make the current comment number a settable field so someone can type in a comment number to jump straight to it.
Design:
Here's an example of what that might look like in the top-right of the review screen on the "Files changed" tab:
In this layout, the
13would be the current comment number I am looking at, out of a total of64review comments. I can clickNext>to jump to the next comment, or<Prevto jump to the previous comment. I can also click on the13and edit it to any number, then press Enter to jump to that comment. The64is not editable directly.This would make the review process soooo much easier.
It is CRITICAL that #1786 is also implemented so that we NEVER EVER EVER lose review comments! Any obsolete review comments which can no longer be attached to a file or line or commit should be attached to the PR directly still and just placed at the very top of the "Files changed" tab in chronological order, for all parties to still look at and resolve, edit, or comment on them! SOME COMMENTS ARE CRITICALLY IMPORTANT and this is the only way to give a reviewer power to ensure their really really important review comments are properly implemented before they approve.
Here is a summary of the message I just sent to Github. If you'd like to see these issues implemented too, contact GitHub yourselves and let them know! Feel free to copy and paste the message I've used below, or write your own, linking back to these issues you care about.