Skip to content
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
This repository was archived by the owner on Nov 18, 2021. It is now read-only.

2 of 3) Have a button to "show/expand all comments" in the "Files changed" tab! #1787

@ElectricRCAircraftGuy

Description

@ElectricRCAircraftGuy
  1. Part 1 of 3: 1 of 3) Keep ALL review comments even when git commit history is changed #1786
  2. Part 2 of 3: this issue
  3. Part 3 of 3: 3 of 3) Show the number of comments in the "Files changed" tab and have buttons for "next comment" and "previous comment" #1788

Sometimes comments I leave are really really important to me because they are bugs that must be fixed before the code is merged! When I'm looking at the "Files changed" tab, however, these comments are frequently obsolete and missing (see #1786), or are folded/collapsed with an "outdated" or "resolved" marker. Please add a button or check-box to the top-right of the "Files changed" review tab to "show/expand all comments". This way, I can simply click that button then scroll down the page to look at my comments.

It also allows me to put keyword into really important comments, such as "BLOCKING", then I could click this "show/expand all comments" button and do a Ctrl + F find in my browser to search for "BLOCKING" on the page. This way I could really quickly find all comments I really cared about and make sure they are implemented BEFORE I CLICK APPROVE!

If Part 1 of this request (#1786) was also implemented, I could also scan the "detached/obsolete" comments at the top of the "Files changed" section to make sure they are all implemented as well!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions