Skip to content
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
This repository was archived by the owner on Nov 18, 2021. It is now read-only.

1 of 3) Keep ALL review comments even when git commit history is changed #1786

@ElectricRCAircraftGuy

Description

@ElectricRCAircraftGuy
  1. Part 1 of 3: this issue
  2. Part 2 of 3: 2 of 3) Have a button to "show/expand all comments" in the "Files changed" tab! #1787
  3. Part 3 of 3: 3 of 3) Show the number of comments in the "Files changed" tab and have buttons for "next comment" and "previous comment" #1788

1 of 3: keep ALL review comments even when git commit history is changed! This means, when someone rebases onto latest master then force-pushes to their PR, my really important review comments I left and want to make sure were implemented are still there. Related: #997.

The best way to do this is to simply identify if a comment can be attached to a current file and line, and if not, stick it at the very top of the "Files changed" review tab instead, so all can see the comment exists!

Sometimes REALLY Important requests are made via comments, and we CANNOT afford for these comment to get lost just because the owner of the PR rebased! Currently, the comment may continue living in the "Conversation" tab, but it gets buried under an "Outdated" comment fold, making it VERY HARD to find!

ALL COMMENTS MUST REMAIN AT THE TOP OF "Files changed" tab instead please. Do NOT fold (collapse) them by default on this page either. They may be very important. Let a user collapse them once they see they are implemented.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions