You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
1 of 3: keep ALL review comments even when git commit history is changed! This means, when someone rebases onto latest master then force-pushes to their PR, my really important review comments I left and want to make sure were implemented are still there. Related: #997.
The best way to do this is to simply identify if a comment can be attached to a current file and line, and if not, stick it at the very top of the "Files changed" review tab instead, so all can see the comment exists!
Sometimes REALLY Important requests are made via comments, and we CANNOT afford for these comment to get lost just because the owner of the PR rebased! Currently, the comment may continue living in the "Conversation" tab, but it gets buried under an "Outdated" comment fold, making it VERY HARD to find!
ALL COMMENTS MUST REMAIN AT THE TOP OF "Files changed" tab instead please. Do NOT fold (collapse) them by default on this page either. They may be very important. Let a user collapse them once they see they are implemented.
1 of 3: keep ALL review comments even when git commit history is changed! This means, when someone rebases onto latest master then force-pushes to their PR, my really important review comments I left and want to make sure were implemented are still there. Related: #997.
The best way to do this is to simply identify if a comment can be attached to a current file and line, and if not, stick it at the very top of the "Files changed" review tab instead, so all can see the comment exists!
Sometimes REALLY Important requests are made via comments, and we CANNOT afford for these comment to get lost just because the owner of the PR rebased! Currently, the comment may continue living in the "Conversation" tab, but it gets buried under an "Outdated" comment fold, making it VERY HARD to find!
ALL COMMENTS MUST REMAIN AT THE TOP OF "Files changed" tab instead please. Do NOT fold (collapse) them by default on this page either. They may be very important. Let a user collapse them once they see they are implemented.