Fix uv run due to missing ppisp ref#5791
Conversation
Greptile SummaryThis PR fixes a missing
Confidence Score: 5/5Safe to merge — the change adds two missing lines to register the Both additions are minimal and correct: the dependency declaration matches the already-present No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[uv run / uv sync] --> B{Resolve dependencies\nfrom pyproject.toml}
B --> C[isaaclab-ppisp listed\nin dependencies]
C --> D{Look up source\nin tool.uv.sources}
D --> E[isaaclab-ppisp\npath = source/isaaclab_ppisp\neditable = true]
E --> F[Install from local path\nas editable package]
F --> G[Environment ready]
style C fill:#90EE90
style E fill:#90EE90
Reviews (1): Last reviewed commit: "Merge branch 'develop' into mh/fix_uvrun..." | Re-trigger Greptile |
There was a problem hiding this comment.
Review Summary
Clean fix for a missing package reference. The isaaclab_ppisp submodule exists in source/ but was not included in the root pyproject.toml, causing uv run to fail when resolving dependencies.
Changes Reviewed
pyproject.toml (+2 lines)
- Added
isaaclab-ppispto thedependencieslist - Added corresponding
[tool.uv.sources]entry pointing tosource/isaaclab_ppisp
Assessment
✅ Correctness: The fix properly adds the missing package reference in both required locations (dependencies and sources).
✅ Alphabetical ordering: The new entries are correctly placed between isaaclab-physx and isaaclab-rl, maintaining the existing alphabetical convention.
✅ Path format: The source path source/isaaclab_ppisp follows the established pattern using underscores in directory names while the package name uses hyphens.
Minor Consideration
This appears to be a straightforward omission fix. For future similar issues, it might be worth adding a CI check that validates all source/isaaclab_* directories have corresponding entries in pyproject.toml to catch missing references early.
LGTM from a code perspective. No blocking concerns.
|
pls also create a PR to cherry-pick this to the release branch |
# Description Fix missing uv source for ppisp submodule ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
… locomanip quaternion, deformable demo, IK, benchmark scripts (#5816) # Description Cherry pick following PRs from develop: - #5779 - #5760 - #5791 - #5810 - #5811 - #5812 - #5754 - #5802 - #5803 - #5782 - #5804 - #5744 - #5775 - #5784 --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: John <jaybdub@users.noreply.github.com> Co-authored-by: myurasov-nv <168484206+myurasov-nv@users.noreply.github.com> Co-authored-by: Antoine RICHARD <antoiner@nvidia.com> Co-authored-by: Mike Yan Michelis <46975745+mmichelis@users.noreply.github.com> Co-authored-by: hujc <jichuanh@nvidia.com>
Description
Fix missing uv source for ppisp submodule
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there