Fixes nvbug#5760
Conversation
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This PR adds a helpful documentation note explaining Windows-specific behavior when _isaac_sim\\setup_conda_env.bat is missing from Isaac Sim binary installations. The change is straightforward: a 10-line .. note:: block in the RST docs and an empty changelog skip file.
Design Assessment
✅ Correct approach - Adding a note directly in the conda environment setup section where users will encounter the issue is the right place.
✅ Appropriate placement - The note is positioned inside the Windows tab-item, right after the conda activate command, which is contextually correct since this is when users would encounter the error.
Findings
RST Syntax Review:
- ✅ The
.. note::directive is properly formatted - ✅ Indentation aligns correctly with the parent Windows tab-item (15 spaces for directive, 18 spaces for content)
- ✅ Blank line after directive before content body
- ✅ Inline code formatting with double backticks is correct
Content Review:
- ✅ Accurately describes the behavior (non-fatal warning → PYTHONPATH error later)
- ✅ Identifies the root cause (missing
setup_conda_env.batin some binary zips) - ✅ Provides actionable solutions (re-extract build or set env vars manually)
Minor observation: The note uses backslash in _isaac_sim\\setup_conda_env.bat which is Windows-appropriate for this context.
Test Coverage
- Documentation-only change: no tests needed.
- Changelog skip file correctly added.
CI Status
⏳ CI checks still in progress. One failure observed in isaaclab_tasks [1/3] - appears unrelated to this docs-only PR.
Verdict
No issues found ✅
Clean documentation addition that will help Windows users diagnose a confusing error. Ready to merge once CI passes.
Update (b424ad2): New commit updates ThreeDWorld URL in ecosystem.rst from www.threedworld.org to the GitHub repo github.com/threedworld-mit/tdw. ✅ No issues — valid URL fix for external reference.
Update (6bca1df): Major CI/infrastructure commit with several improvements:
- Added
exclude-patterninput torun-testsandrun-package-testsactions for flexible test filtering - Replaced Python-level
TESTS_TO_SKIPrendering test exclusions with CI-levelexclude-pattern: "test_rendering_"on task shard jobs (dedicated rendering-correctness jobs still run them ✅) - Folded standalone
verify-base-non-rootandverify-curobo-non-rootjobs intotest-isaaclab-ovandtest-curoborespectively (saves runner slots while preserving the regression check) - Added JUnit XML upload steps across CI workflows for better test reporting
- Added
libgmp-devto arm64 Dockerfile deps for pytetwild build
No issues found. Parameter position shifts in run-tests shell function are correctly propagated. Legacy "not " merge logic properly combines with explicit exclude-pattern. All changes are consistent and well-commented.
Greptile SummaryThis is a documentation-only closeout PR for a batch of NVBugs, where the runtime fixes were already merged in earlier PRs. The only new content here is a Windows conda install note and a broken-link fix.
Confidence Score: 5/5Documentation-only changes with no runtime code modifications; safe to merge. Both changed .rst files contain small, targeted edits — a broken external link update and a well-scoped Windows install note — with no logic, configuration, or dependency changes. The .skip file is an empty sentinel that only affects towncrier changelog generation. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User runs isaaclab.bat --conda on Windows] --> B{setup_conda_env.bat present?}
B -- Yes --> C[Isaac Sim env vars exported successfully]
B -- No --> D[Non-fatal warning printed]
D --> E[Isaac Sim env vars NOT exported]
E --> F["Error: Isaac Sim is not installed or not found on PYTHONPATH"]
F --> G{Resolution}
G --> H[Re-extract a build that includes setup_conda_env.bat]
G --> I[Manually set Isaac Sim env vars before running isaaclab.bat]
Reviews (2): Last reviewed commit: "Fix broken ThreeDWorld doc link (threedw..." | Re-trigger Greptile |
|
@greptileai review |
|
pls also create a PR to cherry-pick this to the release branch |
Fixes NVBug 5984996. - Documentation update - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` since CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Fixes NVBug 5984996. - Documentation update - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` since CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
… locomanip quaternion, deformable demo, IK, benchmark scripts (#5816) # Description Cherry pick following PRs from develop: - #5779 - #5760 - #5791 - #5810 - #5811 - #5812 - #5754 - #5802 - #5803 - #5782 - #5804 - #5744 - #5775 - #5784 --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: John <jaybdub@users.noreply.github.com> Co-authored-by: myurasov-nv <168484206+myurasov-nv@users.noreply.github.com> Co-authored-by: Antoine RICHARD <antoiner@nvidia.com> Co-authored-by: Mike Yan Michelis <46975745+mmichelis@users.noreply.github.com> Co-authored-by: hujc <jichuanh@nvidia.com>
Description
Fixes NVBug 5984996.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.tomlsince CI handles that)CONTRIBUTORS.mdor my name already exists there