[SYCL][Doc] Add Graph Scheduler design documentation#1457
Merged
bader merged 9 commits intointel:syclfrom Apr 15, 2020
Merged
Conversation
Co-authored-by: Vlad Romanov <vlad.romanov@intel.com> Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
AGindinson
reviewed
Apr 2, 2020
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com> Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
Contributor
sergey-semenov
left a comment
There was a problem hiding this comment.
Most of these are minor grammar/style comments.
romanovvlad
reviewed
Apr 3, 2020
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com> Co-Authored-By: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com> Co-Authored-By: Sergey Semenov <43845535+sergey-semenov@users.noreply.github.com>
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com> Co-Authored-By: Sergey Semenov <43845535+sergey-semenov@users.noreply.github.com>
…duler_docs * origin/sycl: (26 commits) [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492) [BuildBot] Improve usability of buildbot scripts (intel#1472) [NFC] Add GitHub actions badges to README file (intel#1496) [SYCL] Improve error handling for kernel invocation (intel#1209) [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371) [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465) [CI] Download fixed versions of Python tools (intel#1485) [SYCL] Fix sub_group::broadcast (intel#1482) [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488) [SYCL] Only export public API (intel#1456) [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475) [SYCL] Enable LIT testing with CUDA BE (intel#1458) [SYCL] Fix float to half-type conversion (intel#1395) [NFC] Cleanup unneded macro from builtins implementation (intel#1445) Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479) [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480) [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466) [SYCL][USM] Remove vestigial dead code (intel#1474) [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451) [Driver][SYCL] Emit an error if c compilation is forced (intel#1438) ...
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
keryell
reviewed
Apr 10, 2020
Contributor
keryell
left a comment
There was a problem hiding this comment.
Thanks for fixing and improving the comments. This is always appreciated!
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Contributor
Author
|
@keryell @AlexeySachkov does it look better now? |
keryell
previously approved these changes
Apr 15, 2020
Contributor
keryell
left a comment
There was a problem hiding this comment.
That looks quite better! :-)
…duler_docs * origin/sycl: [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) [SYCL] Fixed sub-buffer memory allocation update (intel#1486) [SYCL] Ensure proper definition of spirv builtins for SYCL (intel#1393) [SYCL][CUDA] LIT XFAIL/UNSUPPORTED (intel#1303) [SYCL][Doc] Function-type kernel attribute extension (intel#1494)
romanovvlad
approved these changes
Apr 15, 2020
| /// kernel should be executed. | ||
| /// | ||
| /// The commands that contain explicit memory operations include copy, fill, | ||
| /// update_host and other operations. It's up to implementation how to define |
Contributor
There was a problem hiding this comment.
Suggested change
| /// update_host and other operations. It's up to implementation how to define | |
| /// update_host and other operations. It's up to implementation how to implement |
??
Contributor
Author
There was a problem hiding this comment.
I wonder if repetition in such cases is a stylistic mistake...
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 21, 2020
…c_abi_checks * origin/sycl: [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545) [SYCL] [xmethods] Allow replacing xmethod script (intel#1532) [SYCL] Add tests for inline asm feature (intel#1444) [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540) [SYCL][USM] Remove unused header and unnecessary includes (intel#1537) Fix check-llvm dependencies (intel#1547) [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531) [SYCL][Doc] Add static local memory query extension. (intel#1539) [SYCL][Doc] Add sycl_bitcast extension (intel#1541) [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533) [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529) [SYCL] Fix processing of spec consts referenced twice (intel#1524) [SYCL] Use correct macro name in export.hpp (intel#1527) [Driver][NFC] Fix -help information for -Xs options (intel#1530) [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457) [SYCL] Add diagnostics for long double in device code (intel#1512) [SYCL] Add a mutex to state-modifying program functions (intel#1204) [SYCL][Test] Add Devicelib tests (intel#1256) [SYCL] Refactor semantic checks for variable types (intel#1513)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Vlad Romanov vlad.romanov@intel.com
Signed-off-by: Alexander Batashev alexander.batashev@intel.com