[SYCL][CUDA] Fix LIT testing with CUDA devices#1300
Merged
bader merged 1 commit intointel:syclfrom Apr 12, 2020
Merged
Conversation
Author
|
WARNING This PR fixes CUDA LIT testing and multiple LIT tests will unexpectedly pass while more will fail. A follow up PR will fix this as I didn't want to overload this PR. ninja check-sycl-cuda
...
Unexpected Passing Tests (2):
SYCL :: basic_tests/boolean.cpp
SYCL :: hier_par/hier_par_basic.cpp
SYCL :: kernel_from_file/hw.cpp
********************
Failing Tests (7):
SYCL :: backend/cuda/primary_context.cpp
SYCL :: basic_tests/handler/handler_copy_with_offset.cpp
SYCL :: basic_tests/handler/handler_mem_op.cpp
SYCL :: group-algorithm/all_of.cpp
SYCL :: group-algorithm/broadcast.cpp
SYCL :: group-algorithm/any_of.cpp
SYCL :: group-algorithm/exclusive_scan.cpp
SYCL :: group-algorithm/leader.cpp
SYCL :: group-algorithm/inclusive_scan.cpp
SYCL :: group-algorithm/none_of.cpp
SYCL :: group-algorithm/reduce.cpp
SYCL :: program_manager/env_vars.cpp
SYCL :: multi_ptr/multi_ptr.cpp
SYCL :: scheduler/DataMovement.cpp
SYCL :: scheduler/MultipleDevices.cpp
SYCL :: usm/allocator_vector.cpp
SYCL :: usm/allocatorll.cpp
SYCL :: usm/allocator_vector_fail.cpp
SYCL :: usm/badmalloc.cpp
SYCL :: usm/depends_on.cpp
SYCL :: usm/dmemll.cpp
SYCL :: usm/hmemll.cpp
SYCL :: usm/memadvise.cpp
SYCL :: usm/memcpy.cpp
SYCL :: usm/memset.cpp
SYCL :: usm/mixed.cpp
SYCL :: usm/mixed2.cpp
SYCL :: usm/mixed_queue.cpp
SYCL :: usm/mixed2template.cpp
SYCL :: usm/queue_wait.cpp
SYCL :: usm/smemll.cppAnd the following two tests hang when run for CUDA: basic_tests/device_event.cpp
regression/group.cppFollow up PR to rework: #1303 |
bjoernknafla
commented
Mar 12, 2020
bjoernknafla
commented
Mar 12, 2020
75d856f to
1a33ab8
Compare
fwyzard
added a commit
to fwyzard/llvm
that referenced
this pull request
Mar 14, 2020
romanovvlad
suggested changes
Mar 18, 2020
fwyzard
added a commit
to cms-patatrack/llvm
that referenced
this pull request
Mar 21, 2020
# Conflicts: # sycl/test/lit.cfg.py
Contributor
|
@bjoernknafla ping |
1a33ab8 to
556d275
Compare
Author
|
I have updated the list of failing and now also hanging tests. I will first rework the PR that fixes LIT tests before this PR can go in. |
This was referenced Mar 27, 2020
Contributor
|
@bjoernknafla, could you take a look at merge conflicts, please? |
Author
|
@bader Will do. |
556d275 to
01a0e92
Compare
bjoernknafla
commented
Apr 9, 2020
sycl/test/lit.cfg.py
Outdated
Author
There was a problem hiding this comment.
On a fail LIT prints out this information and eases running the test by hand. Though the user still needs to add the LD_LIBRARY_PATH to find the SYCL library, but that is not part of this change.
bjoernknafla
commented
Apr 9, 2020
sycl/tools/CMakeLists.txt
Outdated
Author
There was a problem hiding this comment.
I removed this to avoid duplication and instead use the cudadrv target set up in the sycl/plugin/cuda/CMakeLists.txt CMake file.
bjoernknafla
commented
Apr 9, 2020
01a0e92 to
379636c
Compare
Build the `get_device_count_by_type` tool with the required preprocessor definitions to enable CUDA, and link with CUDA. Pass correct backend name to the `get_device_count_by_type` tool that is required to run tests with PI OpenCL instead of PI CUDA. Clean up the `get_device_count_by_type` tool code to make it harder to call it with the wrong backend and get unexpected query results back. Signed-off-by: Bjoern Knafla <bjoern@codeplay.com>
379636c to
aee267f
Compare
Contributor
|
@romanovvlad, please, approve to unblock merge. |
Author
|
There is an open change request that GitHub cannot identify as the commit (due to rebasing) is gone... |
romanovvlad
approved these changes
Apr 10, 2020
Contributor
|
@bjoernknafla, basic_tests/buffer/buffer_dev_to_dev.cpp seems to hang. Do you know why? |
Author
|
I haven’t seen |
Contributor
|
I've restarted the job and it passed. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 15, 2020
…duler_docs * origin/sycl: [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) [SYCL] Fixed sub-buffer memory allocation update (intel#1486) [SYCL] Ensure proper definition of spirv builtins for SYCL (intel#1393) [SYCL][CUDA] LIT XFAIL/UNSUPPORTED (intel#1303) [SYCL][Doc] Function-type kernel attribute extension (intel#1494)
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 15, 2020
…c_abi_checks * origin/sycl: (32 commits) [SYCL] Do not force LLVM_INCLUDE_TESTS variable (intel#1505) [SYCL][NFC] Align nd_item members with constructor initialization list (intel#1521) [SYCL] Move get_info_host implementation to header (intel#1514) [SYCL] Always use dynamic CRT for Unit tests (intel#1515) [SYCL][NFC] Temporarily disable sporadically failing test (intel#1526) [SYCL] Fix inline namespaces (intel#1525) [SYCL] Release notes for March'20 DPCPP implementation update (intel#1511) [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the
get_device_count_by_typetool with the required preprocessordefinitions to enable CUDA, and link with CUDA.
Passed correct backend name to the
get_device_count_by_typetool tois required to run tests with PI OpenCL instead of PI CUDA.
Clean up the
get_device_count_by_typetool code to make it harder tocall it with the wrong backend and get unexpected query results back.
Signed-off-by: Bjoern Knafla bjoern@codeplay.com