[SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations#1371
Merged
bader merged 18 commits intointel:syclfrom Apr 8, 2020
Merged
[SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations#1371bader merged 18 commits intointel:syclfrom
bader merged 18 commits intointel:syclfrom
Conversation
added 5 commits
March 19, 2020 17:14
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
vladimirlaz
reviewed
Mar 23, 2020
vladimirlaz
reviewed
Mar 23, 2020
AGindinson
reviewed
Mar 23, 2020
Contributor
AGindinson
left a comment
There was a problem hiding this comment.
Personally, I'd prefer to see a more concrete commit message:
[SYCL][Driver] Fix SYCL standards' handling for 'fsycl-device-only' invocations
added 4 commits
March 24, 2020 09:53
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Contributor
@s-kanaev, what do you think here? |
Contributor
Author
Done. |
AGindinson
reviewed
Mar 25, 2020
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
1e815fc to
82db1fa
Compare
bader
reviewed
Mar 26, 2020
AGindinson
reviewed
Mar 31, 2020
Contributor
AGindinson
left a comment
There was a problem hiding this comment.
Got the point why a separate IsSYCL check is needed - the UseSYCLTriple I've suggested before indeed wouldn't have covered all cases. Some regression test comments remaining.
Contributor
|
@s-kanaev, could you resolve comments, please? |
Signed-off-by: Sergey Kanaev sergey.kanaev@intel.com Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
AGindinson
reviewed
Apr 6, 2020
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com> Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
Contributor
|
@s-kanaev, please, take a look at failing tests. |
added 2 commits
April 7, 2020 12:09
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
s-kanaev
commented
Apr 7, 2020
Contributor
Author
Done |
AGindinson
reviewed
Apr 8, 2020
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com> Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
AGindinson
approved these changes
Apr 8, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 9, 2020
…duler_docs * origin/sycl: (26 commits) [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492) [BuildBot] Improve usability of buildbot scripts (intel#1472) [NFC] Add GitHub actions badges to README file (intel#1496) [SYCL] Improve error handling for kernel invocation (intel#1209) [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371) [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465) [CI] Download fixed versions of Python tools (intel#1485) [SYCL] Fix sub_group::broadcast (intel#1482) [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488) [SYCL] Only export public API (intel#1456) [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475) [SYCL] Enable LIT testing with CUDA BE (intel#1458) [SYCL] Fix float to half-type conversion (intel#1395) [NFC] Cleanup unneded macro from builtins implementation (intel#1445) Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479) [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480) [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466) [SYCL][USM] Remove vestigial dead code (intel#1474) [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451) [Driver][SYCL] Emit an error if c compilation is forced (intel#1438) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.