Bump go-github to v46.0.0#1258
Merged
kfcampbell merged 1 commit intointegrations:mainfrom Aug 30, 2022
Merged
Conversation
ef80ef1 to
bebb420
Compare
Signed-off-by: Tobias Gesellchen <tobias@gesellix.de>
bebb420 to
5a3d23c
Compare
Contributor
Author
|
#1263 already upgrades to go-github v47. |
Contributor
Author
|
@kfcampbell would you mind taking a look here? It seems like #1220 and #1263 would benefit from this PR being merged - along with #1198 to be fixed :) |
kfcampbell
approved these changes
Aug 30, 2022
Contributor
kfcampbell
left a comment
There was a problem hiding this comment.
Thanks for doing this!
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
Signed-off-by: Tobias Gesellchen <tobias@gesellix.de> Signed-off-by: Tobias Gesellchen <tobias@gesellix.de>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
Signed-off-by: Tobias Gesellchen <tobias@gesellix.de> Signed-off-by: Tobias Gesellchen <tobias@gesellix.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1198 by using a modern variant of GitHub's Pages api.
Due to go-github v46 including two breaking changes, this is not only a
go get go-githuband ago mod vendor, but includes two code adjustments.1: Support PagesSource as struct for update pages API google/go-github#2407
2: Change DependabotSecretsSelectedRepoIDs to []string google/go-github#2401
go test ./...succeeds locally.