Skip to content

Support PagesSource as struct for update pages API#2407

Merged
gmlewis merged 2 commits intogoogle:masterfrom
gesellix:pages-update
Jul 12, 2022
Merged

Support PagesSource as struct for update pages API#2407
gmlewis merged 2 commits intogoogle:masterfrom
gesellix:pages-update

Conversation

@gesellix
Copy link
Copy Markdown
Contributor

@gesellix gesellix commented Jul 7, 2022

Closes #2406

@gmlewis gmlewis changed the title Support PagesSource as struct for update pages api Support PagesSource as struct for update pages API Jul 7, 2022
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jul 7, 2022

Thank you, @gesellix - please run tests locally and make sure they pass. See CONTRIBUTING.md for more information.

@gesellix
Copy link
Copy Markdown
Contributor Author

gesellix commented Jul 7, 2022

Sorry, my bad - I had read the CONTRIBUTION.md, but ignored them. Obivously 😓
Please leave some feedback if you want me to adjust the other changes or if I should squash the commits.
Thank you, @gmlewis!

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jul 7, 2022
gmlewis
gmlewis approved these changes Jul 7, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gesellix ! There's no need to squash commits, because we always do that upon merge in this repo... thank you, though.
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 7, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2022

Codecov Report

Merging #2407 (24023c4) into master (fd22ee9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2407   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10546    10546           
=======================================
  Hits        10342    10342           
  Misses        140      140           
  Partials       64       64
Impacted Files Coverage Δ
github/repos_pages.go 97.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd22ee9...24023c4. Read the comment docs.

@gesellix
Copy link
Copy Markdown
Contributor Author

gesellix commented Jul 12, 2022

@gmlewis do I have to find someone to review and put another LGTM on this PR? I'm not sure how we can progress on this one. This isn't meant to put any pressure on you or the other maintainers, though :)

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jul 12, 2022

@gesellix - We rely on contributors of this repo to help review the outstanding PRs... feel free to review other open PRs if you have time. 😄
I hate to call out individual contributors, but @Parker77 has been extremely helpful in the past and maybe he has time to review this one to help move it forward.

Parker77
Parker77 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jul 12, 2022

Thank you, @Parker77! We appreciate it.
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 12, 2022
@gmlewis gmlewis merged commit 848f7e4 into google:master Jul 12, 2022
@gesellix
Copy link
Copy Markdown
Contributor Author

gesellix commented Jul 12, 2022

Great, thanks a lot @Parker77 @gmlewis !
I'll certainly try to help with the other reviews, this feels like true open source :)

@gesellix gesellix deleted the pages-update branch July 12, 2022 17:09
@gesellix gesellix mentioned this pull request Aug 19, 2022
Closed
@gmlewis gmlewis mentioned this pull request Aug 19, 2022
Merged
@gesellix gesellix mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@Parker77 Parker77 Parker77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support updated GitHub Pages Update API

3 participants

@gesellix @gmlewis @Parker77